Closed Bug 309902 Opened 19 years ago Closed 19 years ago

Bring back <plaintext>'s properties in html.css

Categories

(Core :: Layout, defect)

x86
Windows 98
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: moz, Assigned: mrbkap)

References

()

Details

(Keywords: fixed1.8, regression, testcase)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

This may be an regession of bug 287990

plaintext is not displayed with white-space:pre and font-family:monospace like
in former versions (I tested with FF1.0.2) and all other browsers.

To fix this is easy. Change this lines in html.css

xmp, pre {
  display: block;
  font-family: -moz-fixed;
  white-space: pre;
  margin: 1em 0;
}

to this:

plaintext, xmp, pre {
  display: block;
  font-family: -moz-fixed;
  white-space: pre;
  margin: 1em 0;
}

Reproducible: Always

Steps to Reproduce:
1. go to URL above or to testcase (coming soon) and note the plaintext element,
it's the grey box.

Actual Results:  
The plaintext element is inline, has no fixed font, white-space is collapsed.

Expected Results:  
The plaintext element is a block element, font is fixed, white-space don't collapse.
Attached file testcase
Component: HTML: Parser → Layout
Keywords: regression, testcase
Summary: Bring back <plaintext>'s properties in html.css → Bring back <plaintext>'s properties in html.css
Oops, I forgot to check the changes to html.css. I'll do that on Monday.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch Fix html.cssSplinter Review
I had this in my tree, even...
Attachment #197440 - Flags: superreview?(bzbarsky)
Attachment #197440 - Flags: review?(bzbarsky)
Comment on attachment 197440 [details] [diff] [review]
Fix html.css

r+sr+a for 1.8
Attachment #197440 - Flags: superreview?(bzbarsky)
Attachment #197440 - Flags: superreview+
Attachment #197440 - Flags: review?(bzbarsky)
Attachment #197440 - Flags: review+
Attachment #197440 - Flags: approval1.8b5+
Fix checked in on trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: