Closed Bug 310393 Opened 19 years ago Closed 19 years ago

Hitting Enter in the searchbar w/o input shouldn't add an empty entry to its autocomplete

Categories

(Firefox :: Search, defect)

1.5.0.x Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: asaf, Assigned: Gavin)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Hitting Enter in the searchbar w/o input shouldn't add an empty entry to its
autocomplete.

STR:
 1. Focus the search bar.
 2. Make sure it's empty.
 3. Hit Enter

-> empty string is added to searchbar's autocomplete.

FYI, at this point, we're opening the search engine site instead of doing a query.
Assignee: nobody → gavin.sharp
Attached patch patchSplinter Review
Attachment #197798 - Flags: review?(bugs.mano)
Status: NEW → ASSIGNED
Comment on attachment 197798 [details] [diff] [review]
patch

r=mano
Attachment #197798 - Flags: review?(bugs.mano) → review+
Trunk:
mozilla/browser/base/content/search.xml; new revision: 1.32;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.6-
Attachment #197798 - Flags: approval1.8b5?
Attachment #197798 - Flags: approval1.8b5? → approval1.8b5+
Whiteboard: [checkin needed][a+]
1.8 Branch: mozilla/browser/base/content/search.xml; new revision: 1.25.2.5;
Keywords: fixed1.8
Whiteboard: [checkin needed][a+]
Target Milestone: Firefox1.6- → Firefox1.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: