Closed Bug 310747 Opened 19 years ago Closed 18 years ago

index.cgi invalid HTML when logged out

Categories

(Bugzilla :: User Interface, defect)

2.21
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: bugreport, Assigned: spam)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

The login form is in the middle of a list but outside an LI


Error at line 85, character 133:  element "FORM" not allowed here; assuming
        missing "LI" start-tag
Keywords: regression
Summary: index.cgi does not validate when logged out → index.cgi invalid html when logged out
I see no interest in having the list of URLs using <ul><li>. We could get the
same UI using <br> between each line. This would also fix this error.
Summary: index.cgi invalid html when logged out → index.cgi invalid HTML when logged out
Having a list, it's generally a good idea to use a ul, since that's what a ul is
for. We could just split up the ul.
What I meant is that we don't need a list here.
Attached patch patch for tip (obsolete) — Splinter Review
took mkanat's approach :-P
Attachment #233213 - Flags: review?
Comment on attachment 233213 [details] [diff] [review]
patch for tip

Note that my HTML Validator complains that the ID and name are different in:

<form id="show-bug" name="f" action="buglist.cgi" method="get"

We can fix that in a separate patch though.

r=LpSolit
Attachment #233213 - Flags: review? → review+
Assignee: myk → bmo
Severity: normal → minor
Flags: approval?
Target Milestone: --- → Bugzilla 3.0
Attached patch patch for tip v2Splinter Review
use same id and name
Attachment #233213 - Attachment is obsolete: true
Attachment #233227 - Flags: review?
Attachment #233227 - Flags: review? → review+
Flags: approval? → approval+
Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.30; previous revision: 1.29
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: