Last Comment Bug 310842 - calRecurrenceInfo.getNextOccurrenceDate: this.mBaseItem.getRecurrenceStartDate is not a function
: calRecurrenceInfo.getNextOccurrenceDate: this.mBaseItem.getRecurrenceStartDat...
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Internal Components (show other bugs)
: unspecified
: x86 Windows 2000
-- normal (vote)
: ---
Assigned To: Mike Shaver (:shaver -- probably not reading bugmail closely)
:
:
Mentors:
Depends on:
Blocks: 310853
  Show dependency treegraph
 
Reported: 2005-10-02 12:53 PDT by gekacheka
Modified: 2005-10-02 15:26 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch: use .recurrenceStartDate, don't set dates to result of dates.push (1002 bytes, patch)
2005-10-02 13:03 PDT, gekacheka
jminta: first‑review+
Details | Diff | Splinter Review

Description User image gekacheka 2005-10-02 12:53:51 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051001 Mozilla Sunbird/0.2+

a couple bugs in calRecurrenceInfo.getNextOccurrenceDate:

this.mBaseItem.getRecurrenceStartDate is not a function

Array.push does not return the array.



Reproducible: Always

Steps to Reproduce:
Comment 1 User image gekacheka 2005-10-02 13:03:53 PDT
Created attachment 198247 [details] [diff] [review]
patch: use .recurrenceStartDate, don't set dates to result of dates.push

(patch -l -p 2 -i file.patch)
Comment 2 User image Michiel van Leeuwen (email: mvl+moz@) 2005-10-02 14:57:36 PDT
Comment on attachment 198247 [details] [diff] [review]
patch: use .recurrenceStartDate, don't set dates to result of dates.push

gekacheka, please set review req
Comment 3 User image Michiel van Leeuwen (email: mvl+moz@) 2005-10-02 14:58:07 PDT
Comment on attachment 198247 [details] [diff] [review]
patch: use .recurrenceStartDate, don't set dates to result of dates.push

(now with fill text) gekacheka, please set review requests, and set them to
sopmebody specific. Otherwise patches will get lost!
Comment 4 User image Joey Minta 2005-10-02 15:11:07 PDT
Comment on attachment 198247 [details] [diff] [review]
patch: use .recurrenceStartDate, don't set dates to result of dates.push

r=jminta.  Can I ask for a little more context in future patches, please? (diff
-pU 8 works nicely)
Comment 5 User image Joey Minta 2005-10-02 15:26:34 PDT
patch checked in.

Note You need to log in before you can comment on or make changes to this bug.