310924 - use X cursor theme for more cursors

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

While the gtk2 widget code makes use of some themeable cursors (those available
in stock gtk2 with gdk_cursor_new), it only uses its builtin images for some
other cursors, like "help" and "copy", which may be available in the X cursor
theme and be used with gdk_cursor_new_from_name.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: first patch

The patch still has some shortcoming:
- themed gdkcursors automatically update themselves when the theme changes.
However in case the previous theme didn't have the cursor and therefore we used
our builtin pixmap, this update does not happen (until the next start, of
course)
- gdk_cursor_new_from_name is only available in gdk 2.8 and the patch uses it
unconditionally. Probably needs to resort to the usual dynamic lib stuff :(

Comment 2

[Adam Guthrie]

*** Bug 336665 has been marked as a duplicate of this bug. ***

Comment 3

[flying sheep]

check out my patch idea on https://bugzilla.mozilla.org/show_bug.cgi?id=609889#c11

Comment 5

[flying sheep]

people, what’s going on? GTK 2.8 is now several years old, time to simply unconditionally depend on it and fix this.

Comment 6

[flying sheep]

funtion to fix is now here: http://hg.mozilla.org/mozilla-central/file/757c2011df5b/widget/gtk/nsWindow.cpp#l4904

Comment 7

[flying sheep]

Attachment: cursors.patch

so, i hope someone sees this.

i did it. all cursors (except the zoom ones) now work with GNOME’s default theme DMZ, and all cursors except the crosshair work in KDE (which is a bug there: https://github.com/ruphy/oxy-cursors/issues/2 and https://bugs.kde.org/show_bug.cgi?id=290356)

Comment 8

[flying sheep]

Attachment: cursors.patch

updated patch with author and stuff

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/068ed8d0e7c2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/068ed8d0e7c2