311019 - label bound to model doesn't work for choices inside of select

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

<xf:select ref="/example/select">
  <xf:label>Flavors</xf:label>
  <xf:choices>
    <!-- You cannot see the label -->
    <xf:label ref="/example/label"/>
    <xf:item>
      <xf:label ref="/example/label"/>
      <xf:value>v</xf:value>
  </xf:choices>
</xf:select>

It is true for <select appearance="compact"/> and <select appearance="full"/>.

Error code lines:

http://lxr.mozilla.org/mozilla/source/extensions/xforms/resources/content/select.xml#334
http://lxr.mozilla.org/mozilla/source/extensions/xforms/resources/content/select.xml#645

Reproducible: Always

Comment 1

[alexander :surkov (:asurkov)]

For bug fixing label control can realize textValue property like it proposes
nsIXFormsLabelElement interface.

Comment 2

[Allan Beaufour]

Attachment: Testcase

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 5

[Allan Beaufour]

Comment on attachment 198424 [details] [diff] [review]
patch

Seems like a good plan to clone them instead. But I do not know if there was a
reason for not to. Doron'll answer that I guess :)

r=me

Comment 6

[alexander :surkov (:asurkov)]

Label can contain arbitrary tags. If label will be cloned then choice label can
have custom look. For example:

<xf:choices>
    <xf:label><span style="color: blue">It's a label</span></xf:label>
    <xf:item

Comment 7

[Doron Rosenberg (IBM)]

checked into trunk

Comment 8

[aaronr]

Reopening bug since the patch hasn't been checked into the branch, yet.

Comment 9

[Doron Rosenberg (IBM)]

checked into branch.