311165 - updates always fail with file in use error after first time

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

STR:
1. set moz_no_remote=1
2. launch a second ffx
3. get an update and apply it
4. FFx gives you the failed to update error msg from bug 306961
5. close one of the two browsers*
6. try to apply update

actual result:
you get the warning message again ... and again ... and again

Expected:
update applies successfully, rabbits mate happily, etc.

(* or close both browsers, or log out and log back in)

Darin, I don't know if this is related to the work you did in bug 306961 or not,
and due to a lack of testcase, don't know if it's specific only to the case
where someone tries to apply an update when moz_no_remote=1. But now my browser
is kinda stuck in this endless update loop, and I'm pretty sure wiping the XML
and MAR files is the only sol'n.

Comment 1

[Darin Fisher]

-> me

Comment 2

[Darin Fisher]

Mike: Actually, can you please upload the "updates/last-update.log" file found
in your Firefox directory?  Thanks!

Comment 3

[Darin Fisher]

Reading through the updater source code, I see some possible cases where we
would treat 'lack of existance of an old file' as an error that we could recover
from without downloading a complete archive.  That's wrong, and it might explain
what you are seeing.  The log file will hopefully reveal what's going on.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: update files from error case

zip contains: update.log, update.manifest, update.mar, update.status

Comment 5

[Darin Fisher]

The patch I'm working on for bug 311266 might help here.

Comment 6

[Darin Fisher]

I'm going to go ahead and mark this bug fixed now that the patch for bug 311266
is in.