311387 - Cannot open local file from "Index of file://" if its file name contains non-ASCII character (if network.standard-url.encode-utf8 is true)

Status: RESOLVED FIXED

(Core :: Networking: File, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We cannot open local file from "Index of file://" if its file name contains
non-ASCII character. If network.standard-url.encode-utf8 is false, it works fine.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

This fixes this bug.

Comment 2

[Darin Fisher]

The patch for bug 284474 will revert network.standard-url.encode-utf8 to false
as it was for Firefox 1.0.x

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 198715 [details] [diff] [review]
Patch rv1.0

this produces wrong results if the scheme just starts with file...

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #3)
> (From update of attachment 198715 [details] [diff] [review] [edit])
> this produces wrong results if the scheme just starts with file...
> 

That's right. We don't know the scheme, but my code is wrong.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 198715 [details] [diff] [review]
Patch rv1.0

Darin:

If the pref is set false in default setting, we may not reproduce with default
settings. But this bug is still there. We should fix this bug. Because I cannot
check all checked-in patch. If default pref is changed in a bug which does not
CC'ed me, this bug may be reproduced until bug 278161 is fixed.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Comment 7

[Zvi Devir]

Duplicate of bug 308159?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 308159 has been marked as a duplicate of this bug. ***

Comment 9

[Zvi Devir]

Since #308159 was marked as dup of this one, I'd like to extend the scope of the
bug.
This bug influences any link to a local file with a non-ASCII-7 filename.
Directory listing is only once aspect of the bug.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> This bug influences any link to a local file with a non-ASCII-7 filename.

of course, please test the patch.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, we cannot reproduce this problem with default settings. But we should fix
this problem on Trunk.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is fixed by bug 261929.

-> FIXED