Closed
Bug 311508
Opened 19 years ago
Closed 19 years ago
If the prefwindow is modal, "Use Current Pages" should use the prefwindow opener as the current pages rather than the last focused browser window
Categories
(Firefox :: Settings UI, defect, P2)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: asaf, Assigned: asaf)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
4.37 KB,
patch
|
mconnor
:
review+
asa
:
approval1.8rc1-
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The "Use Current Pages" button in the preferences window uses the last focuseed browser window as the "Current Pages". This is OK for instant-apply mode (default on OS X / GNOME), but sort of broken if the preference window is modal (default on Windows). Marking this as a regression since the old prefwindow did use the opener.
Assignee | ||
Comment 1•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Priority: -- → P2
Target Milestone: --- → Firefox1.5
Updated•19 years ago
|
Attachment #198883 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 2•19 years ago
|
||
Checking in general.js; /cvsroot/mozilla/browser/components/preferences/general.js,v <-- general.js new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Attachment #198883 -
Flags: approval1.8rc1?
Assignee | ||
Updated•19 years ago
|
Flags: blocking1.8rc1?
Comment 3•19 years ago
|
||
Comment on attachment 198883 [details] [diff] [review] more correctness Mike, we could use your input here. It's not a blocker so we're not gonna get this for rc1, but it does seem like something that needs hashing out.
Attachment #198883 -
Flags: approval1.8rc1? → approval1.8rc1-
Updated•19 years ago
|
Flags: blocking1.8rc1? → blocking1.8rc1-
Comment 4•19 years ago
|
||
Comment on attachment 198883 [details] [diff] [review] more correctness This is bad behaviour we should fix. We fixed similar bugs for 1.0 to not have this problem. Renominating for tomorrow's triage meeting.
Attachment #198883 -
Flags: approval1.8rc1- → approval1.8rc1?
Comment 5•19 years ago
|
||
Comment on attachment 198883 [details] [diff] [review] more correctness This just isn't something we'd stop ship for and it's not the default configuration for what we ship. The negative side effect is minor.
Attachment #198883 -
Flags: approval1.8rc1? → approval1.8rc1-
Comment 6•19 years ago
|
||
I meant to say, not a common action, not "not the default setting"
Assignee | ||
Updated•19 years ago
|
Target Milestone: Firefox1.5 → Firefox1.6-
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 198883 [details] [diff] [review] more correctness This ue-regression fix is baking on the trunk for almost two weeks now and also fixes some brokenness when switching between browser windows in instant-apply mode (the button becomes disabled when it shouldn't). Renominating.
Attachment #198883 -
Flags: approval1.8rc1- → approval1.8rc1?
Comment 8•19 years ago
|
||
Comment on attachment 198883 [details] [diff] [review] more correctness too late for non-critical bugs.
Attachment #198883 -
Flags: approval1.8rc1? → approval1.8rc1-
Assignee | ||
Updated•19 years ago
|
Flags: blocking-aviary2?
Updated•19 years ago
|
Flags: blocking-aviary2? → blocking-aviary2+
Assignee | ||
Updated•19 years ago
|
Attachment #198883 -
Flags: approval1.8.1?
Updated•19 years ago
|
Attachment #198883 -
Flags: approval1.8.1? → approval1.8.1+
Updated•19 years ago
|
Keywords: regression
Whiteboard: [checkin needed (1.8 branch)]
Assignee | ||
Comment 9•18 years ago
|
||
Finally MOZILLA_1_8_BRANCH Checking in general.js; /cvsroot/mozilla/browser/components/preferences/general.js,v <-- general.js new revision: 1.2.8.2; previous revision: 1.2.8.1 done
Keywords: fixed1.8.1
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
Assignee | ||
Updated•18 years ago
|
Version: 1.5.0.x Branch → 2.0 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•