312009 - IMAP capability flags remembered across capability responses

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Scott Talbot]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051011 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051011 SeaMonkey/1.1a

An IMAP server that I (would like to) connect to requires STARTTLS before login
so advertises logindisabled on connect (CAPABILITY IMAP4REV1 <stuff> STARTTLS
LOGINDISABLED), but after STARTTLS it doesn't advertise logindisabled and gives
some login types (CAPABILITY IMAP4REV1 <morestuff> AUTH=PLAIN AUTH=LOGIN).
Mozilla remembers the logindisabled so fails auth thinking that it's denied.

Reproducible: Always

Steps to Reproduce:
1. Connect to IMAP server that requires starttls.

Actual Results:  
Login failed.

Expected Results:  
Logged in.

Comment 1

[Scott Talbot]

Attachment: Forget capability flags.

capability_data() is called on every CAPABILITY response to parse flags out of
the capability so forget flags we know about and start afresh.

Comment 2

[David :Bienvenu]

Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

thx, I thought I'd fixed this, but apparently not.

Comment 3

[Scott Talbot]

I'm not a committer, could someone check this in for me?

Comment 4

[David :Bienvenu]

fixed on trunk, thx.

Comment 5

[David :Bienvenu]

*** Bug 317540 has been marked as a duplicate of this bug. ***

Comment 6

[David :Bienvenu]

Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

we want this for the branch

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

hmm, please consider to add this fix to 1.8.0 branch.
It bakes long enough on 1.8 and trunk, is simple and is kind of security related since it blocks using some secure methods of authentication.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 199140 [details] [diff] [review]
Forget capability flags.

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

checked in for 1.8.0 branch

Comment 10

[David :Bienvenu]

*** Bug 324138 has been marked as a duplicate of this bug. ***