Closed Bug 312391 Opened 19 years ago Closed 19 years ago

Accept languages empties when IE profile migration is selected.

Categories

(Firefox :: Migration, defect)

Product:
Firefox
Component:
Migration
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 2

People

(Reporter: sugar.waffle, Assigned: sugar.waffle)

References

(
URL
)

Details

(4 keywords, Whiteboard: [tjp-dl])

Attachments

(3 files)

screen shot of IE "Priority order of language"
19.50 KB, image/png
Details
screen shot of Firefox languages box
28.16 KB, image/png
Details
Quick patch
562 bytes, patch
masayuki
: review+
mconnor
: superreview+
mconnor
: approval-branch-1.8.1+
dveditz
: approval1.8.0.2+
Details | Diff | Splinter Review 
Reproducible: Always
Steps to Reproduce:
1.Profile migration of IE is selected by making new profile. 
2.Open Tools -> Options -> Advanced -> General ->  Edit Languages

Actual Results:
 The Language list is empty. 

Expected Results:
The IE setting migrate.

Windows XP SP1 + IE6
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051013
Firefox/1.4.1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051013
Firefox/1.4.1 ID:2005101321

Works for me.
Summary: Accept languages empties when IE profile migration is selected. → Accept languages empties when IE profile migration is selected.
The setting of IE is a Japanese, English order like the screen shot.
As for the setting of IE, Migrate is not done to Firefox like the screen shot.
In TranslateLanglist(), 'dest' is not correctly increment.
Therefore, the registry key to IE is not correctly copied. 
 
260   while (source < sourceEnd && *source && dest < destEnd) {
261     if (*source == ',')
262       skip = PR_FALSE;
263     else if (*source == ';')
264       skip = PR_TRUE;
265     if (!skip) {
266       if (comma && *source != ' ')
267         *dest++ = ' ';
268       *dest = *source;
269     }
270     comma = *source == ',';
271     ++source;
272   }
273   *dest = 0;
274 
275   prefs->SetCharPref(aPrefKeyName, prefStringValue);
URL: http://lxr.mozilla.org/mozilla1.8/sou...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Quick patch — — Splinter Review 
The character string copy works normally. 
But because it doesn't have the development environment of Windows, it doesn't 
understand whether to work with Windows.
Assignee: nobody → crot0
Flags: blocking1.8.1?
Comment on attachment 203588 [details] [diff] [review]
Quick patch

Good! This patch works fine! Thank you for you work.
Attachment #203588 - Flags: review+
Attachment #203588 - Flags: superreview?(mconnor)
Status: NEW → ASSIGNED
Flags: blocking1.8.0.2?
Flags: blocking-firefox2?
Attachment #203588 - Flags: superreview?(mconnor) → superreview+
checked-in to Trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 203588 [details] [diff] [review]
Quick patch

The risk is low. The migrator bugs are important for marketing. Let's go to fix on the branches.
Attachment #203588 - Flags: approval1.8.1?
Attachment #203588 - Flags: approval1.8.0.2?
Target Milestone: --- → Firefox 2
Version: 1.5 Branch → Trunk
Attachment #203588 - Flags: approval1.8.1? → branch-1.8.1?(mconnor)
Attachment #203588 - Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
checked-in to 1.8 branch.
Flags: blocking-firefox2?
Keywords: fixed1.8.1, intl
Flags: blocking1.8.0.2? → blocking1.8.0.2+
Comment on attachment 203588 [details] [diff] [review]
Quick patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #203588 - Flags: approval1.8.0.2? → approval1.8.0.2+
This bug still exists when the build uses official branding.
I separated the issue to bug 327303.
-> v.
Status: RESOLVED → VERIFIED
Whiteboard: [tjp-dl]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: