312680 - unknown protocol error produces dialog instead of error page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[James Darpinian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051016 Firefox/1.4.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20051016 Firefox/1.4.1

Visiting a URL with an unknown protocol specified results in an annoying dialog
box instead of a nice error page.  The dialog is in the style of old Firefox 1.0
errors, from before error pages were switched on by deafult.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mike Connor [:mconnor]]

This is an intentional workaround for a more serious bug, which won't be fixable
in the 1.5 timeframe.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 307027 is the more serious bug.

Comment 3

[Jesse Ruderman]

That doesn't make this bug invalid, just not fixable for 1.5.

Btw, the other bug was fixed for 1.5.

Comment 4

[Bob Clary [:bc] (inactive)]

This hits me during automated testing.

Comment 5

[Julian D. A. Wiseman]

A related but easier request has been made in bug 325622.

Comment 6

[Chris Lawson (gone)]

*** Bug 325839 has been marked as a duplicate of this bug. ***

Comment 8

[Gábor Stefanik]

I believe the original problem here was https://bugzilla.mozilla.org/show_bug.cgi?id=306409, which is now fixed. Is this fixable now?

Comment 9

[O. Atsushi (Torisugari)]

Attachment: Patch v1

Let's backout the patch by bug 307027 (attachment 198362 [details] [diff] [review]).

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 538230 [details] [diff] [review]
Patch v1

Seems the original problem was bug 307027 comment 8. Do you have an indication that that one is fixed now? Or have you tested that that bug doesn't occur anymore with this patch?

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 538230 [details] [diff] [review]
Patch v1

I'm going to mark this r- pending a reply to my last comment

Comment 12

[Gábor Stefanik]

(In reply to Christian :Biesinger (don't email me, ping me on IRC) from comment #10)
> Comment on attachment 538230 [details] [diff] [review] [diff] [details] [review]
> Patch v1
> 
> Seems the original problem was bug 307027 comment 8. Do you have an
> indication that that one is fixed now? Or have you tested that that bug
> doesn't occur anymore with this patch?

Comment 8 basically appears to be bug 311007, which is fixed now.

Comment 13

[O. Atsushi (Torisugari)]

I was not in the CC list for some reason. I'm sorry.

(In reply to Christian :Biesinger (don't email me, ping me on IRC) from comment #10)
> Seems the original problem was bug 307027 comment 8. Do you have an
> indication that that one is fixed now?

On trunk, yes. Even if bug 307027 happened to regress, now we can detect it easily;
http://mxr.mozilla.org/mozilla-central/source/docshell/test/chrome/bug311007_window.xul

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 538230 [details] [diff] [review]
Patch v1

ok, sounds good. if we run into problems again, we can always revert this.

my apologies for the delay.

Comment 16

[O. Atsushi (Torisugari)]

Thanks.

Requesting checkin;

"Bug 312680 - Back out bug 307027, for bug 311007 is fixed, r=cbiesinger"

Comment 17

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e8d87ff90d0f

Comment 18

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/e8d87ff90d0f