312928 - Title RSS bug-list based on Saved Search name

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

All the RSS bug-list feeds hardcodes the title to "Bugzilla Bugs".  This
prevents me from migrating all my saved-queries into RSS feeds, for they will
all say "Bugzilla Bugs".  I'm not familiar enough with RSS to know the right way
to fix it, but I think taking advantage of query_based_on URL token would work. 

Reproducible: Always

Steps to Reproduce:

Comment 1

[Albert Ting]

Attachment: suggested patch

Enclosed is my suggestion. I just added the defaultsavename as part of the
title. 
I know the saved name does not necessarily equate to the saved query, nor will
it work if the query wasn't from a saved query.  But it's better than nothing!
:)

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

I couldn't find an easier way of doing this, so I added the param 'title' when the extension is "rss". 'query_based_on' is filtered by buglist.cgi and 'namedcmd' is only used when running a saved search.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 202384 [details] [diff] [review]
patch, v1

>Index: buglist.cgi

>+    # The title of the RSS feed will be the same one as for the bug list.
>+    $vars->{'title'} = $cgi->param('title');

This is a great reuse of the already generated title, because it means the RSS feed title will also get updated if we ever improve the HTML version's title.

r=myk

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Low-risk polish fix. Suitable for checkin during release freeze.

Comment 5

[Frédéric Buclin]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.320; previous revision: 1.319
done
Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.43; previous revision: 1.42
done