Closed
Bug 312934
Opened 19 years ago
Closed 19 years ago
Do not search twice for end-of-line (EOL) character in nsMsgLineStreamBuffer::ReadNextLine
Categories
(MailNews Core :: Networking, defect)
MailNews Core
Networking
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: engel, Assigned: engel)
Details
(Keywords: perf)
Attachments
(1 file)
1.93 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
|nsMsgLineStreamBuffer::ReadNextLine| works as follows. 1) The existing buffer is searched for the EOL character, if it is found, the line is returned. 2) Otherwise, more data is read into the buffer, and 3) the *whole* buffer is searched for the EOL character, see http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/util/nsMsgLineBuffer.cpp&rev=1.39&root=/cvsroot&mark=348,419#398 In step 3), it would be sufficient to only search the data which was just read in.
Assignee | ||
Comment 1•19 years ago
|
||
(also makes the code somewhat easier to read by eliminating the variable |endBufPos|)
Attachment #200007 -
Flags: review?(bienvenu)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Component: Networking: IMAP → MailNews: Networking
Comment 2•19 years ago
|
||
Comment on attachment 200007 [details] [diff] [review] Search EOL in buffer only once I'll test this and drive it in, thx, Hans.
Attachment #200007 -
Flags: review?(bienvenu) → review+
Comment 3•19 years ago
|
||
fixed, Thx, Hans-Andreas.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•