312959 - Hovering over newly-added BM Bar bookmark causes Camino to hang.

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Camino 2005101814 (v1.0a1+)

STR:
1. Visit site above
2. Drag blue globe from tab to BM Bar to create new bookmark
3. After bookmark is created, hover over bookmark

Results:
A few seconds of nothing and then beachball and shortly Activity Monitor reports
Camino is hung

Expected:
Tooltip with full bookmark name and URL

Sample to follow.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sample of Camino hanging

Not sure if today's branch build being so late means anything, but I
experienced this on yesterday's branch build, too.

Comment 2

[Samuel Sidler (old account; do not CC)]

Definitely needs to block. This should block beta.

Comment 3

[Simon Fraser [no longer active]]

It's hanging in -[NSToolTipManager displayToolTip:]. Ugh.

Comment 4

[Simon Fraser [no longer active]]

Turns out that using "\n\n" as a tooltip string hangs Cocoa.

Comment 5

[Simon Fraser [no longer active]]

Attachment: Patch

Patch first avoids the problem by inserting the bookmark after settings its
properties, and secondly checks the tooltip string to make sure it's not
"\n\n".

Comment 6

[Simon Fraser [no longer active]]

+    [theBookmark release];
+    [self insertChild:theBookmark atIndex:aPosition isMove:NO];

These two lines should be swapped in the patch.

Comment 7

[Mark Mentovai]

Comment on attachment 200051 [details] [diff] [review]
Patch

+    if (![tooltipString isEqualToString:@"\n\n"])
+      [self setToolTip:];

Set it to what?

Comment 8

[Simon Fraser [no longer active]]

Attachment: Patch v. 2

Comment 9

[Mark Mentovai]

Comment on attachment 200094 [details] [diff] [review]
Patch v. 2

Nice.

Comment 10

[Mark Mentovai]

Actually, if @"\n\n" is bad, then any other number of @"\n" might also be a
problem.  This could bite us again if the tooltip format ever changes.

Comment 11

[Simon Fraser [no longer active]]

Fixed on trunk and branch.

Comment 12

[dorcassmith]

Long-term Conditions essay services has become very popular among nursing research paper service seekers in need of Long-term Conditions Writing Services and Long-term Conditions assignment writing services.
https://www.meldaresearch.com/long-term-conditions-writing-services/

Comment 13

[Melda]

Do you require Medicine Writing Services and Medicine Research Paper Services? Seek our Online Medicine Essay Writing Services today.
https://www.meldaresearch.com/medicine-essay-writing-2/

Comment 14

[rvlad0101]

Quite recently I met one pretty girl, well, half a year ago, just for me this time flew by very quickly. I met her on a dating site, where you can find many russian mail order brides . I didn’t believe at all that on a dating site you could find a girl for a long relationship, but it turns out I was wrong. This one is even good, because I am happy when I spend time with her. So, who wants to find a soul mate for himself, go to this site.

Comment 15

[Luiza Spectrum]

Today in the world educational system, academic writing is such type of educational control that was introduced in order to see how students well in some specific subjects and how they learn the specific material. Academic writing is one of the core important components of education - within the framework of state policy in the field of education and due to the expediency of increasing publication activity, the discipline "Academic writing" teaches students, graduate students, and researchers to write scientific articles in accordance with the requirements of high-ranking journals. Many students sometimes find it difficult to find a specific scholarly paper and use professional writing companies that can overcome their academic difficulties. In order not to overpay you can use the qualified writing assistance of TopThesis where you can find the options to buy a reliable thesis dissertation https://topthesis.com/ work.