313069 - Javascript error when editing attachments

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P2)

Description

[Joel Peshkin]

There is a javascript error after marking a non-IFRAME-able attachment obsolete
and hitting submit.  In certain versions of IE, this creates a pop-up error box.

Error: big has no properties
Source File: https://...../attachment.cgi?id=24619&action=edit
Line: 315

Comment 1

[Erik Stambaugh]

Attachment: should (?) fix it

I was not able to reproduce the problem, but I can tell what it is.  Someone
who can reproduce it please let me know if this fixes it...

Comment 2

[Joel Peshkin]

Comment on attachment 200157 [details] [diff] [review]
should (?) fix it

yep... that does the trick

To reproduce, watch the javascript console as you edit and attachment that does
not need an IFRAME (like a word doc).  Without commenting (or changing
anything, click SUBMIT).   This will generate an error without this patch.

Comment 3

[Joel Peshkin]

The function in 2.20 is the same.

Comment 4

[Joel Peshkin]

HEAD
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.29; previous revision: 1.28
done

2.20
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.27.4.1; previous revision: 1.27
done

Comment 5

[Teemu Mannermaa (:wicked)]

*** Bug 253453 has been marked as a duplicate of this bug. ***