Closed Bug 313201 Opened 19 years ago Closed 19 years ago

Fix strict warning in utils.js

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [cz-0.9.69])

Attachments

(1 file)

856 bytes, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review
1047 function prompt(msg, initial, parent, title)
1048 {
1049     var PROMPT_CTRID = "@mozilla.org/embedcomp/prompt-service;1";
1050     var nsIPromptService = Components.interfaces.nsIPromptService;
1051     var ps = Components.classes[PROMPT_CTRID].getService(nsIPromptService);
1052     if (!parent)
1053         parent = window;
1054     if (!title)
1055         title = MSG_PROMPT;
1056     rv = { value: initial };

The last line gives a strict warning because rv is not defined. Micro-patch
coming up.
Attached patch PatchSplinter Review
Courtesy of Silver for spotting this and fixing it in 0.9.68.5. Let's make
everyone happy and get this on trunk :-)
Attachment #200284 - Flags: review?(silver)
Blocks: 299458
Comment on attachment 200284 [details] [diff] [review]
Patch

Micro-review=silver ;)
Attachment #200284 - Flags: review?(silver) → review+
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.69]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: