Closed Bug 313448 Opened 19 years ago Closed 13 years ago

votes for bug doesn't include bug summary

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Version:
2.20
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.0

People

(Reporter: timeless, Assigned: mkanat)

References

(
URL
)

Details

(Whiteboard: [fixed by blocker])

Attachments

(1 file, 2 obsolete files)

patch for tip
1.93 KB, patch
LpSolit
: review-
Details | Diff | Splinter Review 
Show Votes
Bug 10000
Who 	Number of votes

Total votes: 0
Blocks: 304064
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 251036 [details] [diff] [review]
patch for tip

>Index: template/en/default/bug/votes/list-for-bug.html.tmpl

>+<h3>Votes for [% terms.Bug %] [% bug_id %] &ndash; [% bug_desc FILTER html %]</h3>

Must be [%+ bug_id FILTER html %], else not only BugXXX is appended, but you also don't pass 008filters.t.

Moreover, please make it a link pointing to bug XXX.
Attachment #251036 - Flags: review? → review-
Attached patch patch for tip (obsolete) — — Splinter Review 

        Attachment #251036 -
        Attachment is obsolete: true

        Attachment #251344 -
        Flags: review?(LpSolit)

    
    

    
  
Comment on attachment 251344 [details] [diff] [review]
patch for tip

Wrong patch

        Attachment #251344 -
        Attachment is obsolete: true

        Attachment #251344 -
        Flags: review?(LpSolit)

    
    

    
  
Comment on attachment 251413 [details] [diff] [review]
patch for tip

The patch itself looks good, but we have to be consistent in the way we display the bug summary. On attachment.cgi and show_bug.cgi, the bug summary is displayed in the header. We should do that too.

        Attachment #251413 -
        Flags: review?(LpSolit) → review-

    
  
OS: Mac OS X → All
Hardware: Macintosh → All
Target Milestone: --- → Bugzilla 3.2

    
    

    
  
Bugzilla 3.2 is restricted to security bugs only. Moreover, this bug is either assigned to nobody or got no traction for several months now. Rather than retargetting it at each new release, I'm clearing the target milestone and the bug will be retargetted to some sensible release when someone starts fixing this bug for real (Bugzilla 3.8 more likely).
Target Milestone: Bugzilla 3.2 → ---

    
    

    
  
Fixed by bug 372979 in Bugzilla 4.0.
Assignee: create-and-change → mkanat
Status: NEW → RESOLVED
Closed: 13 years ago
Depends on: bz-plugin-vote
Resolution: --- → FIXED
Whiteboard: [fixed by blocker]
Target Milestone: --- → Bugzilla 4.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: