313744 - Deadline Field not available when changing several bugs at once

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Alan Johnson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

The deadline field is not available for editing when changing several fields at once. It would be nice to have available to edit for a set of bugs so that we can more easily set schedules for bugfixes.

Reproducible: Always

Steps to Reproduce:
1.Perform a search.
2.Click on "Change several bugs at once"
3.Note that there is no deadline field.

Comment 2

[Albert Ting]

Attachment: v1

This seems like a simple patch.  Unclear how the bugzilla folks want to address the formatting issues.

Comment 3

[Frédéric Buclin]

Comment on attachment 285822 [details] [diff] [review]
v1

>+        <label for="deadline"><b>Deadline (YYYY-MM-DD):</b></label>
>+        <input id="deadline"
>+               name="deadline"
>+               value="[% dontchange FILTER html %]"
>+               size="10" maxlength="10">

About UI: having this field at this place is strange. You should rather group remaining_time and estimated_time together, one below the other, and have deadline on the right. Either that or add a nested table and have them all 3 on the same line (not sure the UI would be nice, though).

About the code itself:
This patch doesn't work at all. If you are in the timetracking group and you don't edit this field, you get the following error:

 '--do_not_c' is not a legal date. Please use the format 'YYYY-MM-DD'.

The reason is that the field has a maxlength of 10, truncating the --do_not_change-- string and process_bug.cgi can then no longer recognize it as a magic string.

Comment 4

[Albert Ting]

My bad, yea, the maxlength causes a problem.  I'll delete it. 

I don't have a preference if the three fields should be on 1 line or two lines.  Unless you have an opinion, how about it looks like this:

    estimated hours                    deadline
    remaining hours

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
>  Unless you have an opinion, how about it looks like this:
> 
>     estimated hours                    deadline
>     remaining hours

That's what I had in mind. :)

Comment 6

[Albert Ting]

Attachment: v2

Updated patch

Comment 7

[Frédéric Buclin]

Comment on attachment 295292 [details] [diff] [review]
v2

>+    <tr>
>       <th><label for="remaining_time">Remaining Hours:</label></th>
>       <td>
>         <input id="remaining_time"

Works fine and the UI is fine. But you should still add two empty cells so that the row above also has 4 cells as other columns. This can be fixed on checkin, so r=LpSolit.

Comment 8

[Frédéric Buclin]

Attachment: patch, v2.1 (checked in)

Here is the patch I'm going to check in.

Comment 9

[Frédéric Buclin]

Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.47; previous revision: 1.46
done

Comment 10

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.