313918 - IME candidate list is positioned to wrong position if the caret is positioned non-root view

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If the editor is positioned non-root view(e.g., the option dialog of Firefox/Thunderbird and the Edit Card dialog of Address Book), the IME candidate list window is positioned wrong position.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

We need to test this patch on non Windows OS.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot of current build

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot of patched windows build

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Bezilla staff:

This patch is changing the XP IME event's reply values.
Could you test this patch on BeOS?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Oops... Sorry. Previous patch is not enough.

Comment 6

[Sergei Dolgov]

I couldnt' reproduce this bug at BeOS, with native IME dialog btw.
May test those changes when new build is finished, but most probably at coming weekend

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 200898 [details] [diff] [review]
Patch rv1.1

Ah... This patch is wrong. I'll create new patch.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv2.0

This patch is "adhoc".
But we select this way in bug 59405. Because, if we select the best way, we need very large change for this bugs. But this adhoc way makes very small change for us.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Bezilla staff:

The new patch changes only Windows code.
Thanks.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Thank you roc!

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Momoi-san(Google) reported that this bug can be reproduced with new chat form on Gmail. And I confirmed it, and the patch for this bug and bug 315457 can fix the bug. We should land the patches to 1.8 branch.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch for 1.8 branch (attachment 201116 and attachment 202190)

This patch is merged the patch for this bug (attachment 201116 [details] [diff] [review]) and the patch for bug 315457 which is regression of this bug (attachment 202190 [details] [diff] [review]). The patches are already working fine on trunk during a long term. r+sr are carried over from the original patches, this patch is not changed anything from them.

Comment 13

[Katsuhiko Momoi]

Thanks Nakano-san for proposing to down integrate the fix into the 1.8 branch. 

Google products have a fairly large number of Firefox 2 users. This bug severely affects Chinese and Japanese users of the following products:

1. Gmail (new UI) that went out last week to some users and will be going to all Gmail users shortly.

* Non-detached chat window at bottom right
* Address Book - Name input field for a new entry

2. Google Spreadsheet: current version at docs.google.com

* All cell input 

3. Google Presentation: current version at docs.google.com

* Link text input window

There are likely to be other products with the same problem -- wherever there is a non-root window.

Please get this in asap for the IME users in these countries. Thanks!

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 287316 [details] [diff] [review]
Patch for 1.8 branch (attachment 201116 [details] [diff] [review] and attachment 202190 [details] [diff] [review])

approved for 1.8.1.10, a=dveditz for release-drivers

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 16

[Al Billings [:abillings - ex-MoCo]]

Masayuki, can you check with the Firefox 2.0.0.10 release candidate at http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2.0.0.10-candidates/rc1/ and verify that this is fixed?

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v. on 1.8.1.10