Closed
Bug 314350
Opened 19 years ago
Closed 19 years ago
implement nsIScrollable::GetScrolledSize()
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: hwaara, Assigned: hwaara)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
1.08 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
I kind of "accidently" implemented this in a proposed fix to bug 222274.
Assignee | ||
Comment 1•19 years ago
|
||
I don't know who to CC for reviews...?
Comment 2•19 years ago
|
||
Well, you can look at the changelog of the file: http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/layout/xul/base/src/nsScrollBoxObject.cpp So I think you could ask bzbarsky, roc, bryner or dbaron.
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 201290 [details] [diff] [review] patch Pretty straightforward patch. Look OK to you, bz?
Attachment #201290 -
Flags: review?(bzbarsky)
Comment 4•19 years ago
|
||
Comment on attachment 201290 [details] [diff] [review] patch >Index: layout/xul/base/src/nsScrollBoxObject.cpp >+ nsIFrame* scrolledBox = GetScrolledBox (this); Why the space before '('? >+ *width = NSToIntRound (scrollRect.width * twipsToPixels); Why not use NSTwipsToIntPixels instead? And again, what's with the space before '('?
Assignee | ||
Comment 5•19 years ago
|
||
(In reply to comment #4) > (From update of attachment 201290 [details] [diff] [review] [edit]) > >Index: layout/xul/base/src/nsScrollBoxObject.cpp > >+ nsIFrame* scrolledBox = GetScrolledBox (this); > Why the space before '('? Well, it's just my coding style, I think it's easier to read that way. > >+ *width = NSToIntRound (scrollRect.width * twipsToPixels); > Why not use NSTwipsToIntPixels instead? And again, what's with the space > before '('? I'll switch to using that function instead.
Comment 6•19 years ago
|
||
> Well, it's just my coding style, I think it's easier to read that way.
Please use prevailing style in the file -- no space there.
Assignee | ||
Comment 7•19 years ago
|
||
Better patch addressing bz's comments.
Attachment #201290 -
Attachment is obsolete: true
Attachment #201290 -
Flags: review?(bzbarsky)
Updated•19 years ago
|
Attachment #201362 -
Flags: superreview+
Attachment #201362 -
Flags: review+
Assignee | ||
Comment 8•19 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 9•18 years ago
|
||
Asking for blocking1.8.1, we need this fix for bug 342841.
Blocks: 342841
Flags: blocking1.8.1?
Updated•18 years ago
|
Attachment #201362 -
Flags: approval1.8.1?
Comment 10•18 years ago
|
||
Comment on attachment 201362 [details] [diff] [review] patch v2 a=mconnor on behalf of drivers, straightforward patch that's needed for a blocker,
Attachment #201362 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 11•18 years ago
|
||
I don't have a branch tree handy, so if anyone wants to land this for me, that'd be great.
Comment 12•18 years ago
|
||
Checking in nsScrollBoxObject.cpp; /cvsroot/mozilla/layout/xul/base/src/nsScrollBoxObject.cpp,v <-- nsScrollBoxObject.cpp new revision: 1.21.12.2; previous revision: 1.21.12.1 done
Keywords: fixed1.8.1
Updated•18 years ago
|
Flags: blocking1.8.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•