314366 - "Enter the path to the file on your computer" assumes I choose a file by entering a path

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Jesse Ruderman]

When I upload a file, Bugzilla says "Enter the path to the file on your computer".  This is wrong because:
(1) I can also choose a file using a file picker.
(2) If I'm using Safari or Firefox (trunk), I can't enter a path directly.

How about "Select a file on your computer"?

Comment 1

[Jesse Ruderman]

Attachment: screenshot in safari

Comment 2

[timeless]

some systems let you enter urls to be uploaded... :)

Comment 3

[victory <[e-mail]>]

How about "Enter the location of the file on your computer"? B-)

Comment 4

[Jesse Ruderman]

I think these extra instructions (such as "Select a file on your computer" and "Describe the attachment briefly.") should be removed completely.  They're pretty redundant.

Comment 5

[Patrick]

Hello, How do I get the file path for this bug?

Comment 6

[Frédéric Buclin]

This bug is just about rewording the existing label.

Comment 7

[Patrick]

I think if it was just 

File: 'Choose File' tab. Would be a lot better than "Select a file on your computer" which is superfluous.

Description is pretty much self explanatory so I'd remove "Describe the attachment briefly" and just have "Brief Description" instead. See rough sketch below of my point.

Comment 8

[Patrick]

Attachment: Rough Sketch.PNG

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 8697534 [details]
Rough Sketch.PNG

Looks good to me.

Comment 10

[Craig Parkinson]

I'm interested in working on this, would it be possible to take this bug? I've located it so far down to field-label.html.tmpl file. Field labels are generated based upon the id passed in, which in this case is bug_file_loc. However I am unsure where the labels get assigned from there. A hint or two would be appreciated.

Comment 11

[Frédéric Buclin]

(In reply to Craig Parkinson from comment #10)
> I've located it so far down to field-label.html.tmpl file.

This is not the right template. Have a look at attachment/createformcontents.html.tmpl.

Comment 12

[Craig Parkinson]

Attachment: v1.diff

I have kept the link for pasting the attachment as text, thereby keeping the same functionality but removing unnecessary wording.

Comment 13

[David Lawrence [:dkl]]

Comment on attachment 8725597 [details] [diff] [review]
v1.diff

Review of attachment 8725597 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 14

[David Lawrence [:dkl]]

Thanks!

ssh://[e-mail]/bugzilla/bugzilla.git
   94baad5..f1c21a5  master -> master