314613 - Extension manager messages in Error Console

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In bug 264537, extension manager update messages sent to the command line were suppressed. The javascript console should have gotten the same treatment, patch coming up. 

This affects Thunderbird too, because this is toolkit code.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Extend the if to include the javascript console

Comment 2

[Benjamin Smedberg]

I'm worried about this: we do want error/warning messages to appear in the JS console by default... the only messages we should be suppressing by default are informational/success messages.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 201512 [details] [diff] [review]
Extend the if to include the javascript console

I agree with Benjamin... I think that the current logging needs some cleaning up but that is going to take quite a bit more work to do properly. This would be a good bug to do this in.

Comment 4

[Robert Strong (they/them - no direct email)]

*** Bug 348405 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

So... why, as a user (say a web developer), would I care about _any_ of these messages?  All they do is clutter up the console and get in the way of me seeing real issues in code that I'm actually trying to fix.

At the very least, shouldn't these follow the chrome error prefs?  But better yet, if logging is not enabled for extension stuff, don't log it!

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 201512 [details] [diff] [review]
Extend the if to include the javascript console

I think we should take this and work out better logging as time permits.

Benjamin, are you ok with this?

Comment 7

[Benjamin Smedberg]

Can't we just control it with a pref? That's what other JS code that uses logging does.

Comment 8

[Robert Strong (they/them - no direct email)]

That is what this patch does... it makes it so we don't dump unless the extensions.logging pref is true.

What I would like is to always log important errors that don't throw and will hopefully have time to revamp this to do so for 3.0

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 201512 [details] [diff] [review]
Extend the if to include the javascript console

Taking this patch from Nick Thomas (cf) so we can hopefully get it for Firefox 2.0. I seldom benefit from these logs currently and believe that extension authors are the main audience that benefits from them... they can just flip the pref.

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 201512 [details] [diff] [review]
Extend the if to include the javascript console

Simple patch to reduce noise in the Error Console.

Comment 11

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 201512 [details] [diff] [review]
Extend the if to include the javascript console

a=beltzner on behalf of drivers for the mozilla_1_8_branch

Comment 13

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH