Closed
Bug 314933
Opened 19 years ago
Closed 18 years ago
initial focus should be on the "Problem type" menulist, not the url field
Categories
(Other Applications Graveyard :: Reporter, enhancement, P5)
Other Applications Graveyard
Reporter
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 1 obsolete file)
1.13 KB,
patch
|
raccettura
:
review+
mtschrep
:
approval1.8.1-
|
Details | Diff | Splinter Review |
Probably as easy as putting a tabindex="0" on it.
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
Comment 1•19 years ago
|
||
This is a near-zero risk change that can only impact reporter. if there's a chance to get it in, it'll make the reporter more functional. if not, I understand.
Flags: blocking1.8rc2?
Comment 2•19 years ago
|
||
Comment 3•19 years ago
|
||
Comment on attachment 201765 [details] [diff] [review] Patch v1 low-risk, doesn't impact anything outside of reporter wizard, and fixes the wizard's behaviour.
Attachment #201765 -
Flags: review+
Assignee | ||
Comment 4•19 years ago
|
||
Does that patch actually work? Seems like the menulist doesn't properly inherit the tabindex attribute.
Assignee | ||
Comment 5•19 years ago
|
||
The other patch didn't work for me, this one does. That one's nicer, and maybe I did something wrong applying it (I don't currently have a build env), so if it works just ignore this.
Comment 6•19 years ago
|
||
Strange that first patch should work according to this: http://xulplanet.com/references/elemref/ref_menulist.html#attr_tabindex Looking at the 2nd patch. Didn't work the first time. Perhaps it's a cache issue.
Comment 7•19 years ago
|
||
Just to add to the confusion, I just recently saw platform dependencies with initial focus (something.focus() didn't help on linux, but helped on windows).
Updated•19 years ago
|
Flags: blocking1.8rc2? → blocking1.8rc2-
Assignee | ||
Updated•18 years ago
|
Priority: -- → P5
Comment 8•18 years ago
|
||
Comment on attachment 201766 [details] [diff] [review] other patch Lets land this
Attachment #201766 -
Flags: review+
Updated•18 years ago
|
Attachment #201765 -
Attachment is obsolete: true
Comment 9•18 years ago
|
||
Comment on attachment 201766 [details] [diff] [review] other patch This should make 1.8.1. UI Fix, no real risk.
Attachment #201766 -
Flags: approval1.8.1?
Updated•18 years ago
|
Summary: inital focus should be on the "Problem type" menulist, not the url field → initial focus should be on the "Problem type" menulist, not the url field
Comment 10•18 years ago
|
||
Comment on attachment 201766 [details] [diff] [review] other patch 181 Drivers realizes that this is a low-risk fix - but we are closing in on our RC1 code freeze and are only at this point taking bugs thats match the criteria for 181 approvals: http://developer.mozilla.org/devnews/index.php/2006/08/28/firefox-2gecko-181-approvals-2/
Attachment #201766 -
Flags: approval1.8.1? → approval1.8.1-
Comment 11•18 years ago
|
||
Checked in on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•