314992 - Update Status "Install Pending" should be localizable

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[dynamis (Tomoya ASAI)]

Software update status "Install Pending" is now hardcoded:
http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2232

This should be splited into updates.properties and read with string bunlde like
other status:
http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/mozapps/update/updates.properties#65
http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1021

  p.s.
This status will be shown under "Update Installed" in the Update History dialog.
Installed and Pending is discrepancy and should be changed.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: patch v1.0

Sorry for letting this sit for so long. This one's simple.

Comment 2

[Darin Fisher]

Comment on attachment 205601 [details] [diff] [review]
patch v1.0

r=darin

Comment 3

[Jesse Ruderman]

Has this patch been checked in?

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 205601 [details] [diff] [review]
patch v1.0

No, this hasn't been. I'd be happy to check it in, but I have no idea what needs to be done for patches that affect localizations. What needs to happen?

Comment 5

[Thomas Bertels]

I don't think anything has to to be done, the localizers sync themselves the translations with the en-US locale by watching it

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Checked in on trunk.

Darin, is it too late for the branch (i.e. your approval-1.8.1+ is still good)?

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 205601 [details] [diff] [review]
patch v1.0

Just making sure it's still ok to check this in.

Comment 8

[Darin Fisher]

Comment on attachment 205601 [details] [diff] [review]
patch v1.0

a=darin on behalf of drivers for the MOZILLA_1_8_BRANCH.  Please add the fixed1.8.1 keyword once this change is committed.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on branch.