31512 - Latest webshell changes break mathML build

Status: VERIFIED FIXED

(Core :: MathML, defect, P3)

Description

[cls]

My tinderbox build that uses --enable-mathml has been broken since the 3/10
carpool landed.  Check twain on the ports page.  

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Ports/952817036.23133.gz


In file included from
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/layout/mathml/base/src/nsMathMLmactionFrame.cpp:44:
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/dist/include/nsIWebBrowserChrome.h:71:
warning: decimal integer constant is so large that it is unsigned
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/layout/mathml/base/src/nsMathMLmactionFrame.cpp:
In function `static nsresult nsMathMLmactionFrame::ShowStatus(nsIPresContext *,
nsString &)':
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/layout/mathml/base/src/nsMathMLmactionFrame.cpp:397:
`do_GetInterface' undeclared (first use this function)
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/layout/mathml/base/src/nsMathMLmactionFrame.cpp:397:
(Each undeclared identifier is reported only once
/opt/home/mozbuild/SunOS_5.7_clobber/mozilla/layout/mathml/base/src/nsMathMLmactionFrame.cpp:397:
for each function it appears in.)
gmake[5]: *** [nsMathMLmactionFrame.o] Error 1

Comment 1

[travis]

Please tell me how to build mathml.  I go into that directory and type 
makefile.win and it fails to build for me and always has.  The webshell changes 
are removal of APIs to convert over to the new model.  There have been postings 
(look on the embedding newsgroup) about what interfaces to use.  You can help 
out by getting the mathml switched over to using the new APIs. I am trying to 
get all this landed sooner rather than later, but the more places that require 
changing the slower and longer it takes.  Since webShell etc is a central place 
for people to tie in, it is used in a number of places.  Because of that I 
can't really change every single client of the old webShell and expect to be 
done anytime soon.  I'm doing my part to try and help people get their stuff 
converted over when possible.

Comment 2

[cls]

rbs would probably be better suited to make the API switchover needed to really
fix mathml.  I forgot to cc him at first.  According to dawn's build document,
you just need to 'set MOZ_MATHML=1' with the rest of the build variables.  Or
you can build it under linux/solaris using --enable-mathml.  

Comment 3

[cls]

Ok, after some digging, I was able to get my build going again by including
"nsIInterfaceRequestor.h" in nsMathMLmactionFrame.cpp.  I checked in the fix.  

Comment 4

[Hixie (not reading bugmail)]

I can build MathML (win32 trunk debug), so I assume this is VERIFIED...