Closed
Bug 315427
Opened 19 years ago
Closed 19 years ago
bad nullcheck in nsXULPrototypeElement::ReleaseSubtree
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: fixed1.8.0.4, fixed1.8.1, memory-leak, Whiteboard: [patch])
Attachments
(1 file)
2.67 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
bryner
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.4+
|
Details | Diff | Splinter Review |
There's a wacky null-check in nsXULPrototypeElement::ReleaseSubtree that causes the rest of the subtree to be skipped. This actually causes a leak when opening the Prefs dialog in Firefox, when the remembered panel is the cache panel (trunk build, Fri Nov 4 15:22:21 PST 2005, Linux/GTK2).
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #202127 -
Flags: superreview?(bryner)
Attachment #202127 -
Flags: review?(bryner)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patch]
Updated•19 years ago
|
Attachment #202127 -
Flags: superreview?(bryner)
Attachment #202127 -
Flags: superreview+
Attachment #202127 -
Flags: review?(bryner)
Attachment #202127 -
Flags: review+
Assignee | ||
Comment 2•19 years ago
|
||
Fix checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Flags: blocking1.8.0.3?
Updated•18 years ago
|
Flags: blocking1.8.0.3? → blocking1.8.0.3+
Assignee | ||
Updated•18 years ago
|
Attachment #202127 -
Flags: approval1.8.0.3?
Attachment #202127 -
Flags: approval-branch-1.8.1?(bryner)
Updated•18 years ago
|
Attachment #202127 -
Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
Comment 4•18 years ago
|
||
Comment on attachment 202127 [details] [diff] [review] patch approved for 1.8.0 branch, a=dveditz for drivers
Attachment #202127 -
Flags: approval1.8.0.3? → approval1.8.0.3+
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•