315451 - User List should have "don't show disabled users" option

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Jim Garrison]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7

The user list page editusers.cgi?action=list would benefit greatly
from a "don't show disabled users" checkbox so that one could work
with only current users in the list when desired.

Reproducible: Always

Steps to Reproduce:

Comment 2

[Tiago Mello [:timello]]

Attachment: v1

A checkbox for "enabled users only" that was checked by default.

Comment 3

[:glob ✱]

Comment on attachment 562908 [details] [diff] [review]
v1

r=glob with the following fixed on commit:

>+  <input type="checkbox" name="enabledonly" value="1" id="enabledonly" checked />

we don't serve xhtml, you don't need to close the input element.

Comment 4

[Frédéric Buclin]

Comment on attachment 562908 [details] [diff] [review]
v1

>=== modified file 'editusers.cgi'

>+        if ($enabled_only eq '1') {
>+            $query .= " $nextCondition profiles.is_enabled = 1 ";
>+        }

Please set nextCondition = 'AND' if this code is triggered, in case future code is added. This was not needed for |if ($grouprestrict eq '1')| only because this check was already done earlier in the code.



>=== modified file 'template/en/default/admin/users/search.html.tmpl'

>+  <input type="checkbox" name="enabledonly" value="1" id="enabledonly" checked />

enabled_only would be more readable + what glob said about XHTML.


>+  <label for="enabledonly">Enabled users only</label>

"Enabled user accounts only" would be more accurate.

Comment 5

[Tiago Mello [:timello]]

Attachment: v2

Comment 6

[:glob ✱]

Comment on attachment 563121 [details] [diff] [review]
v2

r=glob :)

Comment 7

[Frédéric Buclin]

Comment on attachment 563121 [details] [diff] [review]
v2

>=== modified file 'template/en/default/admin/users/search.html.tmpl'

>+  <input type="checkbox" name="enabled_only" value="1" id="enabled_only" checked>

On checkin, please write checked="checked" (as we do elsewhere in the code).

Comment 8

[Tiago Mello [:timello]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                                                                                           
modified editusers.cgi
modified template/en/default/admin/users/search.html.tmpl
Committed revision 7970.

Comment 9

[Frédéric Buclin]

Added to relnotes for 4.4.