Closed Bug 315458 Opened 19 years ago Closed 19 years ago

xulappinfo.js.in should be included via EXTRA_PP_COMPONENTS

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: jag+mozilla)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Patch
856 bytes, patch
benjamin
: review+
neil
: superreview+
Details | Diff | Splinter Review 
The file xulappinfo.js.in uses the preprocessor to include the SeaMonkey version, appname, etc. But this information is only updated the first time the file is created (xulappinfo.js then), since it gets included via EXTRA_COMPONENTS. So when the SeaMonkey version changes, this file does not get updated (except you make clean). The file should be included in the Makefile via EXTRA_PP_COMPONENTS, then it gets preprocessed every compile run.
I'm no expert on that stuff, and I might easily have done something incomplete there... can you tell where in the code that is?
Attached patch Patch — — Splinter Review 
This should fix it i think...xulappinfo.js.in needs to be moved/copied in CVS, will file bug for this then.
Attachment #202397 - Flags: review?
Attachment #202397 - Flags: review? → review?(bsmedberg)
Attachment #202397 - Flags: review?(bsmedberg) → review?(benjamin)
Comment on attachment 202397 [details] [diff] [review]
Patch

You're renaming the source file too, I presume.
Attachment #202397 - Flags: review?(benjamin) → review+
Comment on attachment 202397 [details] [diff] [review]
Patch

Easy review i think :)
Attachment #202397 - Flags: superreview?(neil.parkwaycc.co.uk)
Depends on: 315907
Comment on attachment 202397 [details] [diff] [review]
Patch

Doh, took me this long to figure out the rename issue...
Attachment #202397 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
*** Bug 316198 has been marked as a duplicate of this bug. ***
checked in by Neil.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 202397 [details] [diff] [review]
Patch

requesting branch approval: quite small SeaMonkey-specific fix
Attachment #202397 - Flags: approval1.8rc2?
Attachment #202397 - Flags: approval1.8rc2?
Comment on attachment 202397 [details] [diff] [review]
Patch

re-requesting 1.8 branch approval for this SeaMonkey-only patch
Attachment #202397 - Flags: approval1.8.0.1?
Comment on attachment 202397 [details] [diff] [review]
Patch

oh, wait... one should read all mail before reacting to some ;-)
Attachment #202397 - Flags: approval1.8.0.1?
checked into branch (cleared to land by mtschrep in email to
seamonkey-council).
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: