315810 - Shift modifier used with command-return in location bar or search field fails to open result in foreground

Status: VERIFIED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Chris Lawson (gone)]

Holding the shift key while clicking on a link forces the opposite behaviour of browser.tabs.loadInBackground. However, holding shift while typing cmd-return in either the location bar or the search field fails to switch the behaviour.

Filed as a new bug so as to avoid re-opening bug 201795, which isn't really the same issue (but is where this issue was raised).

This should be pretty easy to fix. I might be able to have a patch ready by the end of the week.

Comment 1

[Chris Lawson (gone)]

Attachment: allows shift to override background pref in location and search bar

Also slightly shortens an earlier bit of appendtabs/replacetabs logic when dragging bookmark folders to open tab bar. If that part's no good, let me know and I'll take it out. It has nothing to do with this bug.

cl

Comment 2

[Chris Lawson (gone)]

Accepting.

cl

Comment 3

[Chris Lawson (gone)]

Attachment: updated per Wevah's suggestions and bugfix

Fixes a problem where if browser.tabs.loadInBackground was FALSE, it wouldn't override. Also dispenses with trying to change the unrelated code; Wevah advised against it (and to be honest, I don't really disagree with him.)

Asking for r from Simon.

cl

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 202862 [details] [diff] [review]
updated per Wevah's suggestions and bugfix

>Index: BrowserWindowController.mm
>===================================================================

>+  BOOL loadInBG  = aShiftIsDown ? ![[PreferenceManager sharedInstance] getBooleanPref:"browser.tabs.loadInBackground" withSuccess:NULL] :
>+                                   [[PreferenceManager sharedInstance] getBooleanPref:"browser.tabs.loadInBackground" withSuccess:NULL];

This is confusing. Read the pref value, then negate it.

Comment 5

[Chris Lawson (gone)]

Attachment: Updated per Simon's suggestion

As requested, now reads pref, then negates.

cl

Comment 6

[Chris Lawson (gone)]

Comment on attachment 202867 [details] [diff] [review]
Updated per Simon's suggestion

sr=pink?

Comment 7

[Simon Fraser [no longer active]]

I landed the patch. Thanks!