Closed Bug 316023 Opened 19 years ago Closed 19 years ago

FTP uploads don't work

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.0beta

People

(Reporter: neil, Assigned: Biesinger)

References

()

Details

(4 keywords, Whiteboard: seamonkey-only code)

Attachments

(1 file)

Regression from bug 298842, one call site got missed.
Attached patch patchSplinter Review
this should do it, but I have no FTP server available to test... can you test it?
Attachment #202656 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #202656 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 202656 [details] [diff] [review]
patch

Seems to work.
Attachment #202656 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #202656 - Flags: superreview+
Attachment #202656 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #202656 - Flags: review+
Checking in xpfe/browser/resources/content/navigator.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v  <--  navigator.js
new revision: 1.583; previous revision: 1.582
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 202656 [details] [diff] [review]
patch

seamonkey-only, low-risk patch to fix ftp upload
Attachment #202656 - Flags: approval1.8rc2?
Flags: blocking-seamonkey1.0b?
Target Milestone: --- → seamonkey1.1beta
Flags: blocking-seamonkey1.0b? → blocking-seamonkey1.0b+
Keywords: regression
Version: unspecified → Trunk
Whiteboard: seamonkey-only code
This bug has blocking-seamonkey1.0b+ set - has this been missed for the beta train?
Comment on attachment 202656 [details] [diff] [review]
patch

a=me for post-deadline landing, as this is marked a beta blocker and is a very easy and low-risk fix.
Attachment #202656 - Flags: approval1.8rc2? → approval-seamonkey1.0+
Checking in xpfe/browser/resources/content/navigator.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v  <--  navigator.js
new revision: 1.577.2.7; previous revision: 1.577.2.6
done
Whiteboard: seamonkey-only code → seamonkey-only code [fixed-seamonkey1.0]
Target Milestone: seamonkey1.1beta → seamonkey1.0beta
Keywords: fixed1.8
(that was MOZILLA_1_8_BRANCH, to be clear)
fixed on MOZILLA_1_8_0_BRANCH
Checking in xpfe/browser/resources/content/navigator.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v  <--  navigator.js
new revision: 1.577.2.4.2.1; previous revision: 1.577.2.4
done
Whiteboard: seamonkey-only code [fixed-seamonkey1.0] → seamonkey-only code
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: