Closed Bug 316087 Opened 19 years ago Closed 19 years ago

a11y: message/alert/help need to be dismissable with ESC key

Categories

(Core Graveyard :: XForms, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: doronr)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1)

Attachments

(2 files)

as per http://www.mozilla.org/access/toolkit-checklist, we need to be able to dismiss message, alert and help popups with the ESC key.
Attached file testcase
Attached patch patch!Splinter Review
Adds a keypress listener to the generated XUL document.

Should we switch the code to use a real .xul file that sets itself up based on the passed in data?
Assignee: aaronr → doronr
Status: NEW → ASSIGNED
Attachment #203035 - Flags: review?(aaronr)
(In reply to comment #2)
> Should we switch the code to use a real .xul file that sets itself up based on
> the passed in data?

Yes we should, but we must be careful to not to allow messages to have chrome privileges.

Comment on attachment 203035 [details] [diff] [review]
patch!

Until we have the XUL file, this patch will get us past the problem.
Attachment #203035 - Flags: review?(aaronr) → review+
Attachment #203035 - Flags: review?(smaug)
Attachment #203035 - Flags: review?(smaug) → review+
Checked into trunk
Whiteboard: xf-to-branch
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0
Whiteboard: xf-to-branch
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED
verfied fixed on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: