316124 - Change throbber images to PNGs or TIFFs, fix bad pixels (also optimize other GIFs)

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Samuel Sidler (old account; do not CC)]

We have one PNG in our throbber list. We should change that to a GIF in line with the others. In addition, I think we can optimize our GIFs a bit more.

Comment 1

[Samuel Sidler (old account; do not CC)]

I'd like this for 1.0, thought it definitely isn't "important".

Comment 2

[Samuel Sidler (old account; do not CC)]

Actually, looking at our current throbber, I think it does need to be in 1.0. Anyone who uses the throbber will see white pixels as it "throbs" (or spins as it were). This is *very* ugly.

Jasper, do you have these images without the dead pixels?

(Note, I'm on 10.4, so this may just show bad with the unified look...)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't see any white pixels in 10.3.9, but boy do those GIFs look awful compared to the PNG in large size (in small size, my default, so much of the detail and clarity is lost, so you can't tell much different between them).

Comment 4

[Samuel Sidler (old account; do not CC)]

Yeah, the GIFs look horrible. We should convert them all to TIFFs with transparency, I think.

I kind of guessed you'd only be able to see the white against the unified style, which is why we missed them for so long...

Comment 5

[Jasper]

Attachment: new TIFF throbber

The zip file contains 12 32px sized optimized TIFF icons for the throbber. The actual spinner is 24px in size. When using the small icons in the toolbar the throbber is as big as it was before (17px).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OMG!  That looks amazing, Jasper!  I can actually see it turning clearly in small mode!

I still think that the "resting state" image should be blank (so you can tell if it's really at rest/page finished or stalled at that particular frame/page stalled in loading, but this looks so much better than the old one that I'd be willing to let that slide for a while (and it looks like having a resting-state image that doesn't also appear in the midst of the animation would require a code change, so...).

Comment 7

[Samuel Sidler (old account; do not CC)]

(In reply to comment #6)
> I still think that the "resting state" image should be blank (so you can tell
> if it's really at rest/page finished or stalled at that particular frame/page
> stalled in loading, but this looks so much better than the old one that I'd be
> willing to let that slide for a while (and it looks like having a resting-state
> image that doesn't also appear in the midst of the animation would require a
> code change, so...).
> 

That's bug 287709 kind of, no?

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #7)
> (In reply to comment #6)
> > I still think that the "resting state" image should be blank  
> That's bug 287709 kind of, no?

Yeah.  I was just elsewhere when I was writing that, and then discovered it needed a code change anyway....

Comment 9

[Samuel Sidler (old account; do not CC)]

WOW. This is such an improvement. Land it! :D

Comment 10

[Samuel Sidler (old account; do not CC)]

This will get fixed when the other icons from bug 314632 land.

Comment 11

[Samuel Sidler (old account; do not CC)]

This is now fixed per the checkin for bug 314632.

Comment 12

[Samuel Sidler (old account; do not CC)]

v on branch and trunk.