316431 - a11y: need mnemonics for buttons on popups

Status: NEW

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[aaronr]

as per http://www.mozilla.org/access/toolkit-checklist, we need to have mnemonics for buttons on our popups.  Like the OK and Cancel buttons, etc.  This would include for message, help, alert and the binding exception dialog.

We've got to make sure that our solution is localizable, too.

However, Mozilla doesn't have mnemonics on OK or Cancel, so maybe there are rules to this we'll have to discover.

Comment 1

[alexander :surkov (:asurkov)]

Are mnemonics enter and escape keys or something else?

Comment 2

[Aaron Leventhal]

No, like Alt+underlined letter. See http://www.mozilla.org/access/keyboard/accesskey

Comment 3

[alexander :surkov (:asurkov)]

Our message dialogs and binding exception dialog contain nothing more than OK button if I'm not wrong. But OK, Cancel, Close buttons don't get accesskeys per http://www.mozilla.org/access/keyboard/accesskey. What is bug about?

Comment 4

[aaronr]

(In reply to comment #3)
> Our message dialogs and binding exception dialog contain nothing more than OK
> button if I'm not wrong. But OK, Cancel, Close buttons don't get accesskeys per
> http://www.mozilla.org/access/keyboard/accesskey. What is bug about?
> 

The accessibility checklist that I was working off of, http://www.mozilla.org/access/toolkit-checklist, doesn't make that level of distinction.  It even says:

# Automatically define mnemonics for all standard common dialogs (like Yes/No confirmations and Retry/Exit error dialogs)
# Support mnemonics in dialogs created via method calls

I guess that this is a question for aaronL, what kinds of things on dialogs need mnemonics and what kinds of things don't?  What about our binding exception dialog with the clickable/tabbable link...does that need a mnemonic for the link that opens the JS console?

Comment 5

[Aaron Leventhal]

The accesskey doc gives complete info. When we update the xul authoring guidelines we'll make that clearer. No accesskeys on Okay and Cancel, but pretty much everything else gets it.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> The accesskey doc gives complete info. When we update the xul authoring
> guidelines we'll make that clearer. No accesskeys on Okay and Cancel, but
> pretty much everything else gets it.
> 

1) I guess to fix the bug we should patch xul:dialog element.
2) if okay and cancel (and some others) buttons of xul:dialog will have accesskeys then author who uses xul:dialog should remember about accesskeys to don't put them in an use at second time. Is it ok? 

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #0)
> as per http://www.mozilla.org/access/toolkit-checklist, we need to have
> mnemonics for buttons on our popups.  Like the OK and Cancel buttons, etc. 
> This would include for message, help, alert and the binding exception dialog.
> 
> We've got to make sure that our solution is localizable, too.
> 
> However, Mozilla doesn't have mnemonics on OK or Cancel, so maybe there are
> rules to this we'll have to discover.
> 

All xforms popups (like message, help, alert and exception dialog) are builded on xul:dialog element, so any mnemonics should be done for it. 

FYI toolkit checklist says: "Automatically define mnemonics for all standard common dialogs (like Yes/No confirmations and Retry/Exit error dialogs)".

Comment 8

[alexander :surkov (:asurkov)]

Though I'm not 100% sure that xul:dialog binding should define these mnemonics because they can broke user defined mnemonics if any.