Closed
Bug 316447
Opened 19 years ago
Closed 12 years ago
inserting an horizontal rule <HR> sets size="2" width="100%"
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: amla70, Assigned: ayg)
Details
Attachments
(1 file)
3.21 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Using the Insert Horizontal rule command in Thunderbird or in a Midas editor inserts <hr size="2" width="100%"> instead of just inserting <hr>
Updated•17 years ago
|
QA Contact: editor
Updated•17 years ago
|
Assignee: mozeditor → nobody
Assignee | ||
Comment 1•12 years ago
|
||
Test: data:text/html,<!doctype html> <div contenteditable>foo</div> <script> getSelection().selectAllChildren(document.body.firstChild); document.execCommand("insertHorizontalRule"); document.body.textContent = document.body.firstChild.innerHTML; </script> Result is <hr style="width: 100%; height: 2px;"> Should be <hr> Confirmed in a mozilla-central build.
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
AFAICT, the attributes were useless anyway, because that's the default height/width for an <hr>.
Attachment #612142 -
Flags: review?(ehsan)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [autoland-try:-u all]
Updated•12 years ago
|
Whiteboard: [autoland-try:-u all] → [autoland-in-queue]
Comment 3•12 years ago
|
||
Comment on attachment 612142 [details] [diff] [review] Patch v1 Review of attachment 612142 [details] [diff] [review]: ----------------------------------------------------------------- I think the original plan was to make these values customizable via prefs, but I don't think we want to do that!
Attachment #612142 -
Flags: review?(ehsan) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [autoland-in-queue] → [autoland-try:-u all]
Updated•12 years ago
|
Whiteboard: [autoland-try:-u all]
Comment 4•12 years ago
|
||
Autoland Patchset: Patches: 612142 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=0c0a0a7cd903 Try run started, revision 0c0a0a7cd903. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=0c0a0a7cd903
Comment 5•12 years ago
|
||
Try run for 0c0a0a7cd903 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=0c0a0a7cd903 Results (out of 219 total builds): success: 181 warnings: 35 other: 3 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-0c0a0a7cd903
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad9d219c1855
Severity: normal → minor
Flags: in-testsuite+
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → mozilla14
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad9d219c1855
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•