Closed
Bug 316452
Opened 19 years ago
Closed 19 years ago
Trademark Review for Mongolian (mn) Firefox 1.5
Categories
(Mozilla Localizations :: Other, defect)
Mozilla Localizations
Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: natsag2000)
References
Details
Attachments
(3 files, 12 obsolete files)
986 bytes,
patch
|
Details | Diff | Splinter Review | |
751 bytes,
patch
|
Pike
:
approval-l10n+
|
Details | Diff | Splinter Review |
824 bytes,
patch
|
Pike
:
approval-l10n-
|
Details | Diff | Splinter Review |
Please bring search engine plugins and bookmarks up-to-date, see the Branch tip of en-US as reference and see http://wiki.mozilla.org/L10n:Firefox_Extras on how to localize them. Please attach a patch for these changes and request approval-l10n. Thanks.
Assignee | ||
Comment 1•19 years ago
|
||
This is updated bookmarks file.
Attachment #203244 -
Flags: approval-l10n+
Assignee | ||
Comment 2•19 years ago
|
||
This is updated dictionary.src file
Attachment #203245 -
Flags: approval-l10n+
Reporter | ||
Comment 3•19 years ago
|
||
Comment on attachment 203244 [details]
Updated bookmarks file
requesting approval works by '?', only me should grant approval with '+'
Attachment #203244 -
Flags: approval-l10n+ → approval-l10n?
Reporter | ||
Updated•19 years ago
|
Attachment #203245 -
Flags: approval-l10n+ → approval-l10n?
Reporter | ||
Comment 4•19 years ago
|
||
Comment on attachment 203244 [details] Updated bookmarks file I made some clarifications to http://wiki.mozilla.org/L10n:Firefox_Extras#Bookmarks, this looks better, but central.html, store and start still need localized links, getfirefox should be removed.
Attachment #203244 -
Flags: approval-l10n? → approval-l10n-
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 203245 [details] Updated dictionary.src file dictionary got removed (at least from list.txt), get rid of it. http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/searchplugins has the current state of the search engines, please make sure that you get the right ones. Either that or request that I check-in-buddy for you, then I'd just copy them over and check them in.
Attachment #203245 -
Flags: approval-l10n? → approval-l10n-
Assignee | ||
Comment 6•19 years ago
|
||
Attachment #203353 -
Flags: approval-l10n?
Reporter | ||
Comment 7•19 years ago
|
||
Comment on attachment 203353 [details]
Updated and corrected files and Start pages, Snippets
startpages should be sent to startpages@, snippets to mlp-staff.
Stuff that is supposed to be added to the l10n frozen branch needs to come as patch, please.
Attachment #203353 -
Flags: approval-l10n? → approval-l10n-
Assignee | ||
Comment 8•19 years ago
|
||
Attachment #203365 -
Flags: approval-l10n?
Assignee | ||
Comment 9•19 years ago
|
||
Attachment #203366 -
Flags: approval-l10n?
Assignee | ||
Comment 10•19 years ago
|
||
Attachment #203367 -
Flags: approval-l10n?
Assignee | ||
Comment 11•19 years ago
|
||
Attachment #203368 -
Flags: approval-l10n?
Reporter | ||
Comment 12•19 years ago
|
||
Comment on attachment 203368 [details] [diff] [review] patch for region.properties file mn.start.mozilla.com. All the search engine related changes should be one patch, dictionary.com is supposed to be removed, not added. I don't see fixes for eBay.src, either, which is not up-to-date, AFAICT. The bookmarks.html still needs to do the "http://www.mozilla.org/" -> "http://www.mozilla.com/" a- on these patches
Attachment #203368 -
Flags: approval-l10n? → approval-l10n-
Assignee | ||
Comment 13•19 years ago
|
||
In the bookmarks.html file "http://www.mozilla.org/" changed to "http://www.mozilla.com/"
Attachment #203396 -
Flags: approval-l10n?
Assignee | ||
Comment 14•19 years ago
|
||
There are only google-mn and wikipedia-mn searchplugins. For now we do not have other popular search plugin's localized sites (eBay, yahoo etc). Do I need send the picture files as an attachment? (google-mn.gif and wikipedia-mn.png)
Attachment #203397 -
Flags: approval-l10n?
Assignee | ||
Comment 15•19 years ago
|
||
Attachment #203398 -
Flags: approval-l10n?
Reporter | ||
Updated•19 years ago
|
Attachment #203396 -
Flags: approval-l10n? → approval-l10n+
Reporter | ||
Comment 16•19 years ago
|
||
Comment on attachment 203397 [details] [diff] [review] searchplugins please do a cvs -z3 diff -uN I can't really tell what you're going to check in otherwise. Same for the other attachement. And please unset your approval request and mark old patches as obsolete, thanks.
Attachment #203397 -
Flags: approval-l10n? → approval-l10n-
Assignee | ||
Updated•19 years ago
|
Attachment #203365 -
Attachment is obsolete: true
Attachment #203365 -
Attachment is patch: false
Attachment #203365 -
Flags: approval-l10n?
Assignee | ||
Updated•19 years ago
|
Attachment #203366 -
Attachment is obsolete: true
Attachment #203366 -
Attachment is patch: false
Attachment #203366 -
Flags: approval-l10n?
Assignee | ||
Updated•19 years ago
|
Attachment #203367 -
Attachment is obsolete: true
Attachment #203367 -
Attachment is patch: false
Attachment #203367 -
Flags: approval-l10n?
Assignee | ||
Updated•19 years ago
|
Attachment #203398 -
Attachment is obsolete: true
Attachment #203398 -
Attachment is patch: false
Attachment #203398 -
Flags: approval-l10n?
Assignee | ||
Comment 17•19 years ago
|
||
(In reply to comment #16) > (From update of attachment 203397 [details] [diff] [review] [edit]) > please do a > cvs -z3 diff -uN > > I can't really tell what you're going to check in otherwise. Same for the other > attachement. > > And please unset your approval request and mark old patches as obsolete, > thanks. > I am so sorry if I am doing trouble for you. Please give me short instruction: In my browser/searchplugins directory, I added google-mn.src, google-mn.gif, wikipedia-mn.src and wikipedia-mn.png files. I removed other files because we don't have localized match. So my question is, how should I make patch files for them? Should I send a result file of "cvs -z3 diff -uN > mydiff.diff" command? or should I just send my added files as an attachment? thank you Thank you
Reporter | ||
Comment 18•19 years ago
|
||
cvs add foo.src for the src files you added, cvs add -kb foo.png for the corresponding images, cvs rm bar.src bar.png for those plugins that you removed and cvs diff -uN will then include the added and removed files in the patch, without the images, which is OK.
Assignee | ||
Comment 19•19 years ago
|
||
Attachment #203244 -
Attachment is obsolete: true
Attachment #203245 -
Attachment is obsolete: true
Attachment #203353 -
Attachment is obsolete: true
Attachment #203368 -
Attachment is obsolete: true
Attachment #203396 -
Attachment is obsolete: true
Attachment #203397 -
Attachment is obsolete: true
Attachment #203700 -
Flags: approval-l10n?
Assignee | ||
Comment 20•19 years ago
|
||
Attachment #203701 -
Flags: approval-l10n?
Assignee | ||
Comment 21•19 years ago
|
||
Attachment #203702 -
Flags: approval-l10n?
Reporter | ||
Comment 22•19 years ago
|
||
I see a whole bunch of check-ins in mn, but no approvals. I don't see any check-in comments either, Natsagdorj, could you please clarify?
Assignee | ||
Comment 23•19 years ago
|
||
(In reply to comment #22) > I see a whole bunch of check-ins in mn, but no approvals. > I don't see any check-in comments either, Natsagdorj, could you please clarify? > I am so sorry. It was all my fault. Just before you wrote me a short instruction, I had wrong understanding of using bugzilla. It was my first time that I wanted to make a change in cvs and ask an approvement in bugzilla after a release lock down. Everything that I made was wrong. ( localizors in irc.mozilla.org are explained me how do I properly make it). I will do my best to that I will never do such a stupid mistake. :) Could you tell me what should I do to correct my mistake?
Reporter | ||
Comment 24•19 years ago
|
||
region.properties should not reference yahoo, if we don't ship it. Rafael, do you approve google-mn, wikipedia-mn for mongolian?
Assignee | ||
Comment 25•19 years ago
|
||
(In reply to comment #24) > region.properties should not reference yahoo, if we don't ship it. Mongolian use yahoo very often, however, we do not have locale yahoo. I don't have other alternative search engine to "browser.search.order.2=" entry. Is that possible to leave it as yahoo? or it must be a localised one ? > Rafael, do you approve google-mn, wikipedia-mn for mongolian? >
Reporter | ||
Comment 26•19 years ago
|
||
Comment on attachment 203700 [details] [diff] [review] Please approve these changes in browser/searchplugins folder This patch landed without approval and removed yahoo.src. So, should mn have yahoo or not?
Attachment #203700 -
Flags: approval-l10n?
Reporter | ||
Comment 27•19 years ago
|
||
Comment on attachment 203701 [details] [diff] [review] changes in list.txt file already landed, non-approved.
Attachment #203701 -
Attachment is obsolete: true
Attachment #203701 -
Flags: approval-l10n?
Reporter | ||
Updated•19 years ago
|
Attachment #203700 -
Attachment is obsolete: true
Reporter | ||
Comment 28•19 years ago
|
||
Comment on attachment 203702 [details] [diff] [review] 2 spelling errors are fixed. already landed without approval
Attachment #203702 -
Flags: approval-l10n?
Assignee | ||
Comment 29•19 years ago
|
||
(In reply to comment #26) > (From update of attachment 203700 [details] [diff] [review] [edit]) > This patch landed without approval and removed yahoo.src. > > So, should mn have yahoo or not? > Is that possible to leave empty the "browser.search.order.2=" entry in the region.properties file? If so, MN should not have yahoo. If not, I need to add yahoo.
Reporter | ||
Comment 30•19 years ago
|
||
You can just remove the line completely, compare-locales is clever enough for that now. Please attach a patch and request approval, do not check in before the patch is approved.
Assignee | ||
Comment 31•19 years ago
|
||
Removed "browser.search.order.2=Yahoo" line completely
Attachment #204725 -
Flags: approval-l10n?
Reporter | ||
Updated•19 years ago
|
Attachment #204725 -
Flags: approval-l10n? → approval-l10n+
Assignee | ||
Comment 32•19 years ago
|
||
landed on the branch
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 33•19 years ago
|
||
Axel, it seems that I need attach a patch again adding a line "browser.search.order.2=" to region.properties file. Because compare-locale.pl gives an error that I need to add these line. What do you think?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 34•19 years ago
|
||
added "browser.search.order.2=" line to the region.properties file, because compare-locale.pl gives an error. Please approve this patch.
Attachment #204772 -
Flags: approval-l10n?
Reporter | ||
Comment 35•19 years ago
|
||
Comment on attachment 204772 [details] [diff] [review] region.properties patch for Mongolian(MN) [fixed 1.8] That's a build config problem, compare-locales is wrong here. It is fixed on the branch, but apparently that is not in the tagged tree for 1.5. I'll have a look.
Attachment #204772 -
Flags: approval-l10n? → approval-l10n-
Reporter | ||
Comment 36•19 years ago
|
||
Build is green now, as the build bug was fixed on the branches.
Reporter | ||
Updated•19 years ago
|
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•