Closed
Bug 318225
Opened 19 years ago
Closed 19 years ago
"Create" button for flags has many leading spaces
Categories
(Bugzilla :: User Interface, defect)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: markhb, Assigned: markhb)
References
()
Details
Attachments
(2 files, 3 obsolete files)
102.40 KB,
image/png
|
Details | |
1.07 KB,
patch
|
Wurblzap
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Fedora/1.0.7-1.1.fc4 Firefox/1.0.7 In template/en/default/admin/flag-type/edit.html.tmpl, there are 5 or more spaces at the end of a line (and one on another) that are included in the value parameter of the input type="button" tag. This results in an ugly, right-justified button. See attached screenshot for an example. Applies to 2.18, 2.20 and tip. Reproducible: Always Steps to Reproduce: 1. Go into a default install of Bugzilla to which you have permission to edit flags 2. Choose "Flags" from the admin menu, then "Create Flag Type for Bugs" 3. See extraneous spaces in button Actual Results: Button contains unnecessary spaces Expected Results: Button should have a Value parameter containing the desired text, trimmed of extra spaces.
Assignee | ||
Comment 1•19 years ago
|
||
This image shows the problem described in the bug.
Assignee | ||
Comment 2•19 years ago
|
||
It's my first-ever patch submission, and I realize it's trivial, but I thought I'd offer it up.
Attachment #204508 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #204508 -
Flags: review? → review?(myk)
Updated•19 years ago
|
Assignee: myk → markhb
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•19 years ago
|
||
Changed to add [%- directives based on Karl's comments in IRC.
Attachment #204508 -
Attachment is obsolete: true
Attachment #204509 -
Flags: review?
Attachment #204508 -
Flags: review?(myk)
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 204509 [details] [diff] [review] Updated to use [%- directive Adding jouni as review requestee.
Attachment #204509 -
Flags: review? → review?(jouni)
Assignee | ||
Comment 5•19 years ago
|
||
Adding patches for 2.18 and the tip.
Attachment #204511 -
Flags: review?(jouni)
Assignee | ||
Comment 6•19 years ago
|
||
Attachment #204512 -
Flags: review?(jouni)
Comment 7•19 years ago
|
||
Comment on attachment 204512 [details] [diff] [review] Patch for the 2.18 branch only security bugs and major bugs are accepted for 2.18.
Attachment #204512 -
Flags: review?(jouni) → review-
Comment 8•19 years ago
|
||
Comment on attachment 204511 [details] [diff] [review] Patch for the tip (2.21.1) Yup, good patch. Thank you :)
Attachment #204511 -
Flags: review?(jouni) → review+
Comment 9•19 years ago
|
||
Comment on attachment 204509 [details] [diff] [review] Updated to use [%- directive No need for a separate 2.20 branch patch. The patch for the tip applies to the 2.20 branch cleanly.
Attachment #204509 -
Attachment is obsolete: true
Attachment #204509 -
Flags: review?(jouni)
Comment 10•19 years ago
|
||
Comment on attachment 204512 [details] [diff] [review] Patch for the 2.18 branch Obsoleting attachment 204512 [details] [diff] [review] (seconding comment 7).
Attachment #204512 -
Attachment is obsolete: true
Updated•19 years ago
|
Flags: approval?
Flags: approval2.20?
Target Milestone: --- → Bugzilla 2.20
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Updated•19 years ago
|
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
Comment 11•19 years ago
|
||
Thanks, Mark! Checking in template/en/default/admin/flag-type/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.13; previous revision: 1.12 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 12•19 years ago
|
||
Oh yeah, branch too (thanks Frédéric): Checking in template/en/default/admin/flag-type/edit.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v <-- edit.html.tmpl new revision: 1.11.4.1; previous revision: 1.11 done
You need to log in
before you can comment on or make changes to this bug.
Description
•