Closed Bug 318624 Opened 19 years ago Closed 19 years ago

xforms and schemaval need to be static for Minimo

Categories

(Core Graveyard :: XForms, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: aaronr)

Details

(Keywords: fixed1.8.0.2, fixed1.8.1)

Attachments

(1 file)

We need to make sure that XForms and Schemavalidation are static for Minimo builds.  dougt says that Minimo probably won't support components aside from possibly components written in JS or only using xpcom glue interfaces.  xpcom is not available as a .dll in Minimo and nspr and JS soon won't be, either.
Attached patch patchSplinter Review
forcing xforms to be static.  Had to include all the MOZ_XUL_APP stuff under an ifndef MINIMO test.  Otherwise rules in rules.mk will force components (like XForms and schemavalidation) to be shared libraries (.dlls) if they xul apps.
Attachment #204732 - Flags: review?(doronr)
Attachment #204732 - Flags: review?(smaug)
Comment on attachment 204732 [details] [diff] [review]
patch

I'm not too familiar with Minimo, but if this makes things to work r=me :)
Attachment #204732 - Flags: review?(smaug) → review+
Attachment #204732 - Flags: review?(doronr) → review+
checked into trunk
Whiteboard: xf-to-branch
checked into MOZILLA_1_8_BRANCH via bug 323691.  Leaving open for now until it gets into 1.8.0
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.0.2
Resolution: --- → FIXED
verified fixed in MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: