319593 - bug_email.pl fails if qa_contact specified in email

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Gabriel Hernandez]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)
Build Identifier: 2.20

While upgrading from version 2.18 to 2.20 we discovered the bug_email.pl script fails if an eamil is submitted that specifies the qa_contact.  We discovered the following line in bug_email.pl is no longer valid:

$Control{'qa_contact'} = DBname_to_id($Control{'qa_contact'});

This line should now read:

$Control{'qa_contact'} = DBNameToIdAndCheck($Control{'qa_contact'});

The DBname_to_id no longer exists in version 2.20.  It has been updated to the module called DBNameToIdAndCheck.

Reproducible: Always

Steps to Reproduce:
1.Send email to Bugzilla instance specifying QA Contact ("@qa_contact=some_name")
2.Nothing happens

Actual Results:  
Nothing happens

Expected Results:  
A Bug is created with a QA Contact specified

None

Comment 1

[Frédéric Buclin]

The qa_contact field should work the same way as the assigned_to field. Using DBNameToIdAndCheck() is a bad idea as it would throw an error instead of writing the error message in an email.

Comment 2

[Gabriel Hernandez]

(In reply to comment #1)
> The qa_contact field should work the same way as the assigned_to field. Using
> DBNameToIdAndCheck() is a bad idea as it would throw an error instead of
> writing the error message in an email.

I'm fine with processing the qa_contact as the subject matter experts deem appropriate.  The pressing issue is that bug_email.pl fails if qa_contact is specified in the email.  The example I provided restores functionality.  If that should NOT be the permanent fix, I'm happy to implement the patch you feel does the job better.

Comment 3

[Frédéric Buclin]

Feel free to submit a patch, I will look at it. Do not forget to request review (review?)

Comment 4

[Gabriel Hernandez]

Sorry, I am not much of a developer.  The example I provided in the original submission was only available to me with the help of a very knowledgeable UNIX admin who works with me.

Comment 5

[fedor ezeev]

Attachment: gabriel's idea as a patch

Comment 6

[Frédéric Buclin]

Comment on attachment 288855 [details] [diff] [review]
gabriel's idea as a patch

bug_email.pl no longer exists and has been replaced by email_in.pl on Bugzilla 3.x. Bugzilla 2.20.x and 2.22.x are restricted to security bugs and crashers.

Comment 7

[Frédéric Buclin]

AFAICS, this bug is no longer valid in email_in.pl.