319691 - Disallow development DBD versions

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P2)

Description

[Max Kanat-Alexander]

We have a *lot* of people run into trouble because they try to install Bugzilla using a development DBD::mysql or DBD::Pg. You can always tell a development version because it has an underscore and then a number at the end.

We just need to die, if we hit a DBD::mysql or DBD::Pg like that.

Comment 1

[Max Kanat-Alexander]

Attachment: Disallow DBD versions with underscores

OK, this should work. I haven't been able to test it, since I don't have a development DBD installed anywhere handy. However, I have tested that it doesn't break normal installs at all.

Comment 2

[Frédéric Buclin]

Comment on attachment 205393 [details] [diff] [review]
Disallow DBD versions with underscores

>+    if ($vok and $pkg =~ /^DBD/ and $vnum =~ /_/) {
>+        print " $vstr\n"
>+              . "   $pkg $vstr is a development version, which Bugzilla"
>+              . " does not support.\n   Downgrade to a version without"
>+              . " an underscore (_) in the version number.";
>+        return !$vok;
>+    }

My opinion is that we should warn the user, but not stop checksetup.pl from running. I would remove "return !$vok;" and keep the warning only.

I'm not going to deny review, but it has not my vote.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> My opinion is that we should warn the user, but not stop checksetup.pl from
> running.

My suggestion would be to add the --force option to ./checksetup.pl to force him to omit this test, for those users who really want to use their dev. DBD despite the warning.

Comment 4

[Marc Schumann [:Wurblzap]]

I'm with Frédéric -- disallowing development DBDs could potentially break working installs all of a sudden. I'd call the parameter something less generic, though, for example --allow-development-dbd or something along these lines.

Comment 5

[Max Kanat-Alexander]

I've never seen a development DBD with a working Bugzilla, but I'll add the parameter.

Comment 6

[Frédéric Buclin]

Comment on attachment 205393 [details] [diff] [review]
Disallow DBD versions with underscores

per previous comments

Comment 7

[Frédéric Buclin]

2.20 and 2.22 have been released. Let's leave them alone.

Comment 8

[Max Kanat-Alexander]

Fixed in bug 360710.