Closed
Bug 320245
Opened 19 years ago
Closed 19 years ago
Package app icons in unix installer
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
1.31 KB,
patch
|
ajschult784
:
review+
neil
:
superreview+
csthomas
:
approval-seamonkey1.0+
|
Details | Diff | Splinter Review |
I just came across the fact that neither the default*.xpm images nor the new seamonkey.png are packaged into our Linux installer and need to be added to the packaging list.
Assignee | ||
Comment 1•19 years ago
|
||
Here's the patch, actually a trivial issue of just adding those images to packages-unix...
Assignee: xpi-packages → kairo
Status: NEW → ASSIGNED
Attachment #205826 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #205826 -
Flags: review?(ajschult)
Attachment #205826 -
Flags: approval-seamonkey1.0?
Updated•19 years ago
|
Attachment #205826 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Updated•19 years ago
|
Attachment #205826 -
Flags: review?(ajschult) → review+
Attachment #205826 -
Flags: approval-seamonkey1.0? → approval-seamonkey1.0+
Comment 2•19 years ago
|
||
Comment on attachment 205826 [details] [diff] [review] add app icons to package list are there files in chrome/icons/default we don't want packaged? if not, should we just do *? (this is fine for now)
Assignee | ||
Comment 3•19 years ago
|
||
(In reply to comment #2) > (From update of attachment 205826 [details] [diff] [review] [edit]) > are there files in chrome/icons/default we don't want packaged? if not, should > we just do *? > (this is fine for now) The reason we don't do * is because not all of them belong into browser.xpi, some belong into mailnews, chatzilla, venkman, inspector etc.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•19 years ago
|
||
Umm, forgot to note in the last comment that I checked this in on trunk and 1.8 branch.
Keywords: fixed1.8
You need to log in
before you can comment on or make changes to this bug.
Description
•