Closed
Bug 320402
Opened 19 years ago
Closed 17 years ago
Bookmarks with long titles have their title "cut off" in Bookmark Bar
Categories
(Camino Graveyard :: Toolbars & Menus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: hwaara, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.8)
Attachments
(2 files)
11.40 KB,
image/png
|
Details | |
1014 bytes,
patch
|
hwaara
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
This is on Camino trunk. Steps to reproduce: 1. Create a bookmark and put it on the bookmark toolbar. 2. Name it something longer than 22 characters 3. The title is cut off where the next bookmark item begins. See the screenshot. I measured, and in my case the item is only allowed to be about 22 chars long.
Reporter | ||
Comment 1•19 years ago
|
||
The full title of the bookmark item in the middle of the picture is "SomaFM: Listener-Supported, Commercial-Free Internet Radio". It's cut off to only show "SomaFM: Listener-Suppo".
Comment 2•19 years ago
|
||
what's your suggestion? that we allow them to be as long as they want?
Summary: Toolbar items with long titles have their title "cut off" → Bookmarks with long titles have their title "cut off" in Bookmark Bar
Reporter | ||
Comment 3•19 years ago
|
||
Yes. If I want them to be smaller, I just edit the title. This is how it's handled in Firefox, IE and other browsers. Safari seems to truncate in the middle, but this is just weird IMHO.
Reporter | ||
Comment 4•19 years ago
|
||
Ok, so concensus on IRC was that we probably should stick to status quo. However: * when dragging a URL to the toolbar, we should pop up a "Rename" dialog similar to what Safari does. -> bug 320410 One remaining question for this bug: how about at least truncating too long bookmark titles?
Comment 5•19 years ago
|
||
any reason why we never used an ellipsis in the first place? just wondering. should we end-truncate? middle truncate? not bother?
Assignee | ||
Comment 6•17 years ago
|
||
This has bugged me for a long time, and it's dirt simple to fix for 10.4+ (the trunk version of this is a one-liner, since we don't have to worry about the SDK or the runtime check)
Assignee: mikepinkerton → stuart.morgan
Status: NEW → ASSIGNED
Attachment #276895 -
Flags: review?(hwaara)
Updated•17 years ago
|
Attachment #276895 -
Flags: superreview+
Reporter | ||
Comment 7•17 years ago
|
||
Comment on attachment 276895 [details] [diff] [review] fix For the record: since we have an infinitely-long bookmarks bar anyways, I would also be fine with allowing bookmark titles to be long, but this is much better than status quo.
Attachment #276895 -
Flags: review?(hwaara) → review+
Assignee | ||
Comment 8•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.7
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•