32108 - Need confirm dialog when cancelling an install download

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, enhancement, P5)

Description

[Jimmy Lee]

Build: 2000-03-16-06-M15-nb1b(WIN), 2000-03-15-16-M15-nb1b(MAC), 
2000-03-16-05-M15-nb1b (LINUX)

1. From http://jimbob/trigger2.html, click drop-down menu and choose 
   a_addsubcomp_bigfile and click Trigger Case button
2. Click Cancel button from Download dialog to cancel download

RESULT:
Dialog dismisses and download appears to have ended.

EXPECTED RESULT:
Confirm dialog appears and inquires if user is certain that he/she wants to end 
the download and understands the consequences of the action.  This is 
user-friendly and behaves as insurance in case this button was selected by 
accident.

Comment 1

[Cathleen]

reassign to dbragg.

Comment 2

[Cathleen]

moving to M16

Comment 3

[Doug Turner (:dougt)]

Nice feature....  It should be a simple Confirm() call.  Maybe two or three 
lines.

Comment 4

[Cathleen]

possibly for Beta3

Comment 5

[Daniel Veditz [:dveditz]]

Parcelling out Cathleen's bugs

Comment 6

[Daniel Veditz [:dveditz]]

Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.

Comment 7

[Erich 'Ricky' Iseli]

Isn't this a duplicate of bug 42872 ? There's already a patch proposed there.

Comment 8

[Peter "jag" Annema]

*** Bug 42872 has been marked as a duplicate of this bug. ***

Comment 9

[Peter "jag" Annema]

Moving patch by Henrik Gemal over from 42872, adding keywords.

Comment 10

[Peter "jag" Annema]

Attachment: [patch] by Henrik Gemal "Hooking up the cancel button in the download dialog"

Comment 11

[Daniel Veditz [:dveditz]]

Resetting target field for missed milestones

Comment 12

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 13

[dbragg]

P5 tasks

Comment 14

[Bruce A. Locke]

Could you please add a config option in either the preferences or hidden in the
configuation files themselves so people can elect to turn off this "feature"?

Thanks...

Comment 15

[dbragg]

Sorry, can't use this patch.  Or, more accurately, this patch is for xpfe
downloads not xpinstall "installation" downloads.  Note the diff.  It's compared
to /mozilla/xpfe/components/xfer/resources/downloadProgress.js

The progress dialog in xpinstall is xpinstall/res/content/xpistatus.xul and .js

I personally feel that this would be an annoying feature.  Note that in Windows
Explorer if you're doing a large copy and hit cancel it simply cancels.  It
seems others agree with me (see above comment from Bruce Locke). 

Comment 16

[Daniel Veditz [:dveditz]]

Why would you want to disable it? How often do people install software? What's 
the cost in frustration if they accidentally cancel a long download?

This patch is not appropriate for this bug, nor is it a duplicate of 42872 
which is an entirely different download dialog.

Comment 17

[Daniel Veditz [:dveditz]]

Since the patch is for the wrong bug this is no longer low-hanging fruit. Hard 
to see how this enhancement moves us toward our customer happiness goal more 
than other problems we've got so taking off the nsbeta1 list.

Comment 18

[Daniel Veditz [:dveditz]]

Don has moved to another group. Install bugs -> syd

Comment 19

[Olav Vitters]

*** Bug 164878 has been marked as a duplicate of this bug. ***

Comment 20

[Graham Perrin]

Close this, maybe?