Closed
Bug 321601
Opened 19 years ago
Closed 19 years ago
[Mac] Support Command+Option+Arrows for tab switching (like Camino)
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey1.1alpha
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
(4 keywords)
Attachments
(1 file, 1 obsolete file)
2.71 KB,
patch
|
stefanh
:
review+
neil
:
superreview+
csthomas
:
approval-seamonkey1.0+
iannbugzilla
:
approval-seamonkey1.1a+
|
Details | Diff | Splinter Review |
This is the xpfe version of bug 275519.
Assignee | ||
Comment 1•19 years ago
|
||
It seems that all field names starts with an underscore (and a few properties as well) so I kept the underscore.
Attachment #206913 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #206913 -
Flags: review?(mnyromyr)
Comment 2•19 years ago
|
||
Comment on attachment 206913 [details] [diff] [review] Make cmd+opt+left/right arrow switch tab on mac I'm not particularly happy with that keys, but since we will "have to buy" them with toolkit later anyways, we might as do so now... Otherwise okay.
Attachment #206913 -
Flags: review?(mnyromyr) → review+
Comment 3•19 years ago
|
||
Comment on attachment 206913 [details] [diff] [review] Make cmd+opt+left/right arrow switch tab on mac Assuming we're not going to change the value you can in fact declare it (without underscore) in the event handler. Or just inline the regexp. Or just ignore it and wait for other platforms with Cmd+Option+Arrow to complain ;-) Nit: doubled space in two of the if statements.
Assignee | ||
Comment 4•19 years ago
|
||
Hmm, should I prefix the constant with a "k"? Looks like no one follows the rules... (transferring mnyromyr's r+)
Attachment #206913 -
Attachment is obsolete: true
Attachment #207352 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #207352 -
Flags: review+
Attachment #206913 -
Flags: superreview?(neil.parkwaycc.co.uk)
Updated•19 years ago
|
Attachment #207352 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 207352 [details] [diff] [review] New version using a constant instead of <field/> a=me for 1.0 and 1.1, one more needed for 1.0 though
Attachment #207352 -
Flags: approval-seamonkey1.1+
Attachment #207352 -
Flags: approval-seamonkey1.0?
Attachment #207352 -
Flags: approval-seamonkey1.0? → approval-seamonkey1.0+
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 8•19 years ago
|
||
Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1.
Keywords: fixed1.8.0.1 → verified1.8.0.1
Assignee | ||
Comment 9•19 years ago
|
||
(In reply to comment #8) > Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; > en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1. Marcia, did you noticed that the "product" is Mozilla App Suite?
Comment 10•19 years ago
|
||
Since Marcia verified this with a Fx build instead of a SM one. Removing verified1.8.0.1 keyword.
Keywords: verified1.8.0.1 → fixed1.8.0.1
Comment 11•19 years ago
|
||
Stefan: Sorry, this was coming up in our query and I did not look at the product closely (did it with another bug too). thanks for Samuel for correcting the keyword. (In reply to comment #9) > (In reply to comment #8) > > Verified on the branch using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; > > en-US; rv:1.8.0.1) Gecko/20060110 Firefox/1.5.0.1. > > Marcia, did you noticed that the "product" is Mozilla App Suite? >
Assignee | ||
Updated•18 years ago
|
Keywords: fixed-seamonkey1.0,
fixed-seamonkey1.1a
You need to log in
before you can comment on or make changes to this bug.
Description
•