323380 - Warning: No inner window available! (nsGlobalWindow::SuspendTimeouts)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jesse Ruderman]

mrbkap noticed this on Linux while investigating bug 303901.  I see it on Mac too.

Steps to reproduce:
1. Open a new tab.
2. Paste data:text/html,<iframe src="?"></iframe> and press enter.
3. Click the Home button.

Result: 

WARNING: No inner window available!, file /Users/admin/trunk/mozilla/dom/src/base/nsGlobalWindow.cpp, line 6949

<mrbkap> So we'll create an outer window for the iframe, but we fail to load the URL ("?"), so we never get around to creating an inner window

<mrbkap> It's interesting that we try to call SuspendTimeouts on an outer window, though.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I'm proposing to fix this by having the frame loader load about:blank if the original uri it's given is invalid.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is this related to bug 322773 at all?

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

It's almost certainly exactly the same bug (from what I can tell) if you want to dupe, then I'll take that bug.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This fixes this bug by attempting to load about:blank if the URI we are originally tring to load is malformed. It doesn't fix bug 322773 because in that case, the URI is well formed, and we're firing the alert from within nsDocShell::LoadURI.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 208748 [details] [diff] [review]
Proposed fix

Makes sense...

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.