Closed Bug 323485 Opened 19 years ago Closed 19 years ago

Xlib build fails in nsGfxFactoryXlib.cpp following bug 322942

Categories

(Core Graveyard :: GFX: Xlib, defect)

x86
Linux
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kherron+mozilla, Assigned: kherron+mozilla)

References

Details

Attachments

(1 file)

Xlib builds fail while compiling nsGfxFactoryXlib.cpp, complaining about NS_SCREENMANAGER_CID not found. Bug 322942 moved nsIScreen and its implementations from gfx to widget; it included fixes for the major gfx implementations but not xlib.
Attached patch Xlib fixSplinter Review
This contains the code changes. It's based on the patch in bug 322942 and the BeOS patch in bug 323352. I've verified that xlib builds and runs with this change.

The files files nsScreenManagerXlib.cpp, nsScreenManagerXlib.h, nsScreenXlib.cpp, and nsScreenXlib.h were copied from gfx/src/xlib to widget/src/xlib and currently appear in both directories. I presume the gfx versions should be removed via cvs as part of the checkin.
Attachment #208529 - Flags: superreview?
Attachment #208529 - Flags: review?
Attachment #208529 - Flags: superreview?(pavlov)
Attachment #208529 - Flags: superreview?
Attachment #208529 - Flags: review?(cbiesinger)
Attachment #208529 - Flags: review?
Attachment #208529 - Flags: superreview?(pavlov) → superreview+
Attachment #208529 - Flags: review?(cbiesinger) → review+
Checked in. Thanks for the quick reviews!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: