Closed
Bug 323485
Opened 19 years ago
Closed 19 years ago
Xlib build fails in nsGfxFactoryXlib.cpp following bug 322942
Categories
(Core Graveyard :: GFX: Xlib, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kherron+mozilla, Assigned: kherron+mozilla)
References
Details
Attachments
(1 file)
6.21 KB,
patch
|
Biesinger
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
Xlib builds fail while compiling nsGfxFactoryXlib.cpp, complaining about NS_SCREENMANAGER_CID not found. Bug 322942 moved nsIScreen and its implementations from gfx to widget; it included fixes for the major gfx implementations but not xlib.
Assignee | ||
Comment 1•19 years ago
|
||
This contains the code changes. It's based on the patch in bug 322942 and the BeOS patch in bug 323352. I've verified that xlib builds and runs with this change. The files files nsScreenManagerXlib.cpp, nsScreenManagerXlib.h, nsScreenXlib.cpp, and nsScreenXlib.h were copied from gfx/src/xlib to widget/src/xlib and currently appear in both directories. I presume the gfx versions should be removed via cvs as part of the checkin.
Attachment #208529 -
Flags: superreview?
Attachment #208529 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #208529 -
Flags: superreview?(pavlov)
Attachment #208529 -
Flags: superreview?
Attachment #208529 -
Flags: review?(cbiesinger)
Attachment #208529 -
Flags: review?
Updated•19 years ago
|
Attachment #208529 -
Flags: superreview?(pavlov) → superreview+
Updated•19 years ago
|
Attachment #208529 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 2•19 years ago
|
||
Checked in. Thanks for the quick reviews!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•