323732 - Missing cursors resources in Windows build that are needed for the -moz-xxx CSS cursor style.

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect, P1)

Description

[David Marteau]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; fr; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; fr-FR; rv:1.8.0.1) Gecko/20060111 (XulRunner)

The cursors resources are missings in xul.dll, this make special -moz CSS
cursor style declarations ineffective.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Benjamin Smedberg]

Is there a minimal testcase I can use to make sure a patch works?

Comment 2

[Benjamin Smedberg]

Attachment: Build widget resources into libxul, rev. 1

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 323730 has been marked as a duplicate of this bug. ***

Comment 4

[Benjamin Smedberg]

bryner, I'm hoping to fix this for 1.8.0.2, can you have a look?

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 208749 [details] [diff] [review]
Build widget resources into libxul, rev. 1

r=me, assuming that the RCINCLUDE in libxul-config.mk is sufficient to get the resources compiled in to the dll (not sure what the make rule is for that)

Comment 6

[Benjamin Smedberg]

Fixed on trunk.

Comment 7

[Benjamin Smedberg]

David, can you please verify that this is fixed in XULRunner nightly builds from today?

Comment 8

[David Marteau]

(In reply to comment #7)
> David, can you please verify that this is fixed in XULRunner nightly builds
> from today?
> 

I have checked the latest win32 build (latest 1.8.0.1 from 08-Feb-2006 17:22:00) and cursors resources are still missing in xul.dll ( I hope I have checked the correct build ).

Comment 9

[Benjamin Smedberg]

Since this was checked in yesterday, we're going to need a build dated today (Feb 9). Try http://stage.mozilla.org/pub/mozilla.org/xulrunner/tinderbox-builds/solaria-trunk/xulrunner-1.9a1.en-US.win32.zip

Comment 10

[David Marteau]

>http://stage.mozilla.org/pub/mozilla.org/xulrunner/tinderbox-builds/solaria-trunk/xulrunner-1.9a1.en-US.win32.zip

Checked the latest : resources are still missing.

Comment 11

[Benjamin Smedberg]

Could you please indicate what testcase you're using?

Comment 12

[Benjamin Smedberg]

Attachment: Supplementary patch

Comment 13

[David Marteau]

(In reply to comment #11)
> Could you please indicate what testcase you're using?
> 

I have noticed the problem with my current application, using -moz-grab css cursor style with a mouseover event. I've rapidly found that that corresponding cursors resource in the xul.dll file should be in the resource id range 4100 to 4110 (the grab cursor ID is 4101). 
Adding directly the missing resources in the xul.dll file solve the problem at my level ( an utility like 'resHacker' can do the job).

Comment 14

[Benjamin Smedberg]

Supplementary patch checked in trunk. Please check subsequent nightlies or tinderbox builds and report back.

Comment 15

[Benjamin Smedberg]

David, ping?

Comment 16

[David Marteau]

(In reply to comment #15)
> David, ping?
> 

Sorry, was busy elsewhere.

Latest nightly build (2006021309) at ftp.mozilla.org does not fix the problem. I have provided a small testcase at http://daim.project.free.fr/xul that test for the 'cursor:-moz-grab' css style, and a hacked version of the xulrunner distro. Anyway resources are still missing in xul.dll file. 

Comment 17

[David Marteau]

Checked the last nightly build (windows build 2006021509) , cursors resources are missing in xul.dll.

Comment 18

[Benjamin Smedberg]

Are you sure you're grabbing the right builds? Your testcase WFM on trunk builds.

This patch has not yet been checked in on 1.8 branch or 1.8.0 branch builds.

Comment 19

[David Marteau]

Sorry, you're right  : I have checked the build from ftp://ftp.mozilla.org/pub/mozilla.org/xurlrunner/nightly/latest-mozilla1.8.0

It's working for me for the trunk (checked last 1.9a1 build). Checked testcase and for cursors in xul.dll resources.