323839 - Toolbar overflow causes parts of webpage to bounce and the UI to extend beyond the edge of the screen

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matt Lemieux]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060117 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060117 Firefox/1.6a1

When I use the GoogleBar with the search term highlighting turned on, it prints each word of the search query as a button on the toolbar. As these buttons extend beyond the edge of the viewable screen, the UI extends in an attempt to fit the extended length. However, when the window is maximized, this causes the scrollbar to move past the edge of the viewable screen. It also causes problems with divs that have relative placement. They start to bounce between their normal position and the position they would be if the screen were wide enough to hold the entire UI.

Reproducible: Always

Steps to Reproduce:
1. Using a toolbar extension, cause the items on the toolbar to overflow
2. Observe how the UI extends past the end of the viewable screen.
3. Watch certain divs begin to "bounce".

Actual Results:  
Bad Webpage and UI rendering

Expected Results:  
Toolbar buttons cut off gracefully, The UI doesn't extend past the edge of the viewable screen, and relatively placed divs don't bounce.

Possibly relation to Bug 247116, Bug 316340

Comment 1

[Matt Lemieux]

Attachment: Screenshot of overflow

This is a screenshot showing the overflow and the extension of the UI beyond the edge of the viewable screen (I included the entire screen for reference).

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060117 Firefox/1.6a1 ID:2006011721
WFM. It replaces the previous search like in branch.
The extension is not compatible with trunk builds BTW. 

Comment 3

[Ria Klaassen (not reading all bugmail)]

See http://img3.imageshack.us/img3/464/google1iy1.png

Comment 4

[Aaron]

You have to use enough search terms that the buttons that appear for "find in page" go off the end of the toolbar. I get the same problem. Try it in 1024 by 768 resolution.

Comment 5

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #4)
Aha, the arrow doesn't appear.  

Comment 6

[Ria Klaassen (not reading all bugmail)]

This changed between 6 and 7 Oct 2005 so I suspect Bug 243078.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-10-06+06%3A00%3A00&maxdate=2005-10-07+06%3A00%3A00&cvsroot=%2Fcvsroot

Comment 7

[Aaron]

I'm not sure what you mean by it changing between October 6th and 7th. I only started using the nightlies around the time that 1.5b1 came out.

I also don't see the connection to the bug you mentioned. This has nothing to do with shadows...

Not only does the arrow disappear, but it makes things bounce back and forth on the screen. A good way to see this is to install the Forecastfox extension and set it to display in the statusbar. When you make Googlebar overflow it will jump back and forth violently. Some times you need to open and close a couple tabs before this behavior kicks in.

Comment 8

[Ria Klaassen (not reading all bugmail)]

Oh well, I know what has caused this. In toolbar.css one has forgotten to define a minimum width for the toolbar.

toolbar {
  min-width: 1px;
}

Putting this line in userChrome.css fixes the problem for me.

Comment 9

[Martijn Wargers (dead)]

Attachment: patch

Ria, you should write your own patches :-)
This patch fixes this bug and bug 319222.
It basically puts back in what was removed (wrongly, as you can see with this bug) by the patch for bug 243078, see:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=toolbar.css&branch=&root=/cvsroot&subdir=mozilla/toolkit/themes/winstripe/global&command=DIFF_FRAMESET&rev1=1.9&rev2=1.10

Comment 10

[James Ross]

The fix as described in this bug has landed as part of bug 313388.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/toolbar.css&rev=1.12#55

If this has not fixed this bug fully, please reopen with details.