324553 - Finish remote container API

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Brett Wilson]

Comment 1

[Brett Wilson]

Attachment: Patch

In addition to the container API, this patch also:
- Renames BookmarksContainer to RemoteContainer
- Removes RESULT_TYPE_DAY which was unimplemented, and replaced it with RESULT_TYPE_REMOTE_CONTAINER to identify remote containers that are not bookmark folders.
- Fixes a bug in BookmarkService::RemoveFolderChildren
- Replaces leaky calls to QueryStringToQueries with a new nsCOMArray version that should be less error-prone
- Replaces most uses of nsINavHistoryQuery arrays to use COM arrays of the concrete class, which simplified a lot of code
- Fixes a bunch of signed/unsigned warnings in the livemark service
- Cleaned up result containers to remove the unused access count and time parameters in the constructors.
- Renamed the serialized version of bookmark folders from "folders=" to "folder=" since there is only one folder per item, which was confusing even me.

Comment 2

[Brett Wilson]

On trunk and 1.8 branch.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv