3246 - {list} [BLOCK] List numbering code is inefficient

Status: RESOLVED WORKSFORME

(Core :: Layout: Block and Inline, defect, P3)

Description

[vidur (gone)]

Since list renumbering happens for any block frame, this is potentially a O(n^2)
algorithm. I was looking at this when I hooked up attribute changes for lists
and list items. If you make modifications to list renumbering, look at the
AttributeChanged method for nsBlockFrame. You will notice that I renumber lists
when a list item's "value" attribute is changed. The code currently makes the
assumption that the renumbering must be done by the first block ancestor of the
list item. If you modify list renumbering to make different assumptions about
parenting, please modify this code as well. (test to come)

Comment 1

[leger]

putting on [Perf] radar

Comment 2

[leger]

Updating to default Layout Assignee...kipp no longer with us :-(

Comment 3

[troy]

Why are you re-reassing layout bugs? Do NOT touch layout bugs.

The bugs are assigned to Kipp so they can stay neatly organized until we have a
new owner for the block/inline code.

Comment 4

[leger]

Bulk add of "perf" to new keyword field.  This will replace the [PERF] we were
using in the Status Summary field.

Comment 5

[buster]

kipp is very unlikely to fix these, since he's not working ont he project any 
longer.  so I'll take a look.

Comment 6

[buster]

another possibly "future" perf bug.

This bug has been marked "future" because we have determined that it is not 
critical for netscape6.0. 
If you feel this is an error, or if it blocks your work in some way -- please 
attach your concern to the bug for reconsideration.

Comment 7

[Hixie (not reading bugmail)]

putting on the nsbeta1 radar for consideration by engineering

Comment 8

[Arthur]

Cc'ing myself. Is this still an issue?

Comment 9

[Markus Hübner]

Reassigning ...

Comment 10

[Mats Palmgren (inactive)]

The testcase in bug 881090 hangs in nsBlockFrame::RenumberListsInBlock / RenumberListsFor.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 12 votes.
:jfkthame, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 12

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 13

[Jonathan Kew [:jfkthame]]

The testcase mentioned in comment 10 seems to load without any problem now; closing this as WFM.

If there's some other testcase that still exhibits the issue, please file a new bug with details.